Bug 846080
| Summary: | NIS user causes gdm autologin to fail, user isn't valid yet? | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Rick Berge <rfdb> | ||||||||
| Component: | ypbind | Assignee: | Honza Horak <hhorak> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Jakub Prokes <jprokes> | ||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | 6.2 | CC: | jprokes, mmuzila, ovasik, psklenar, tlavigne, todoleza | ||||||||
| Target Milestone: | rc | Keywords: | Patch | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | i686 | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: |
Cause:
ypbind is not checked when the set timeout is too short
Consequence:
Not possible to start gdm with autologin on using NIS.
Fix:
Use configured timeout value and check if binding was successful even if the timeout is set to 0.
Result:
gdm with autologin on using NIS works properly
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-07-22 06:44:37 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 947782, 1159825 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Rick Berge
2012-08-06 18:50:24 UTC
For a few seconds after service should be valid,
ypwhich: Can't communicate with ypbind
Looking at the ypbind service script,
echo -n $"Binding NIS service: "
# the following fixes problems with the init scripts continuing
# even when we are really not bound yet to a server, and then things
# that need NIS fail.
timeout=10
firsttime=1
SECONDS=0
while [ $SECONDS -lt $timeout ]; do
if /usr/sbin/rpcinfo -p | LC_ALL=C fgrep -q ypbind
then
if [ $firsttime -eq 1 ]; then
# reset timeout
timeout=$NISTIMEOUT
firsttime=0
fi
/usr/bin/ypwhich > /dev/null 2>&1
retval=$?
if [ $retval -eq 0 ]; then
break;
fi
fi
sleep 2
echo -n "."
done
This is looping for only timeout=10 seconds. For whatever reason, it needs 18 seconds on this system/network. Note the ability to reset the timeout to NISTIMEOUT, which defaults to 45, but only if rpcinfo finds ypbind.
I'll attach two patches folks can play with. The first alternative just bumps the timer. The second alternative brings back the control loop from ypbind-1.19-11.el5 (but I didn't check why it was replaced.)
Created attachment 602864 [details]
Increase timer for checking rpc availability of ypbind
Option 1, increased the timer in the service
Created attachment 602870 [details]
el5's way of checking rpc availability of ypbind
Option 2, use the simpler loop logic from el5's ypbind
Thanks for reporting. Do I understand correctly, that increasing timer as you suggest in comment #3 (not using $NISTIMEOUT) fixes your issue? Yes. Either patch will fix things. I think the second patch is better, since it makes things use only a single timer value, which is already configurable. Created attachment 603304 [details] use configured value and check even if it is zero Then it seems you hit the same issue as mentioned in Fedora: https://bugzilla.redhat.com/show_bug.cgi?id=624688#c23 If we used a solution from comment #4, rpcinfo wouldn't be executed at all if NISTIMEOUT=0, which is not correct. We still want to check if binding was successful in that case, so I'd propose something like the patch attached. Can you check if it works for you? Works for me. I'm all for using the same code as the other branch. Thanks. Sorry, the reproducer above is not correct, this one could be better: 1. configure ypbind 2. #> service rpcbind stop 3. #> service ypbind restart Actual results: service ypbind restart takes 10s Expected results: service ypbind restart takes 45s (or whatever is defined in $NISTIMEOUT either in /etc/sysconfig/network or in /etc/sysconfig/ypbind. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1332.html |