Bug 846234
Summary: | Review Request: Lightread - A totally awesome offline Google Reader | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Vadim Rutkovsky <roignac> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | d.g.cameron, mhall119, msuchy, package-review, roignac, vrutkovs |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | NotReady | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2015-07-21 13:46:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Vadim Rutkovsky
2012-08-07 08:48:32 UTC
Hi Vadim, The spec file must be directly accessible, not embedded in a web page, and the link to the SRPM gives a 404. These problems need to be fixed before any review can be done. Hi David, Here is a direct link to Spec - https://raw.github.com/roignac/Specs/master/lightread.spec An updated SRPM can be found here - http://download.opensuse.org/repositories/home:/roignac/Fedora_17/src/lightread-1.0.20.git20120808-1.1.src.rpm Errors from rpmlint: lightread.noarch: W: incoherent-version-in-changelog 1.0.20-1 ['1.0.20.git20120808-1.1', '1.0.20.git20120808-1.1'] lightread.noarch: E: dir-or-file-in-opt /opt/extras.ubuntu.com/lightread/bin/lightread lightread.noarch: W: percent-in-%postun It's bad to define your own bindir, and it is forbidden to install anything to /opt. Please try to stick to the filesystem layout in the guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines#Filesystem_Layout and avoid creating any directories called "Ubuntu" :) David, thanks for comments. These directories (and /opt usage) are used and harcoded in upstream, so I'll prepare a pull request, which will fix this behaviour. I'll post a new comment with spec and SRPM links when these changes will be adopted by upstream *Please* try to keep your Package Review request up-to-date or mark it as NotReady: https://fedoraproject.org/wiki/Package_Review_Process Currently, the links to the spec and the src.rpm give 404 once again, so there is nothing available to take a look at. Not even an older package that may lead to reviewer's comments that would still apply in the next package release. Installing to /opt/extras.ubuntu.com/ is only there for submitting the package to Ubuntu's MyApps portal[1]. If you are converting that version of the Debian package to an RPM, you'll want to change the target installation directory to one appropriate for Fedora/RedHat. [1] http://developer.ubuntu.com/publish/my-apps-packages/ Ping! Any progress here? The project is dead (same as Google Reader), closing |