Bug 846744
| Summary: | Review Request: libmate - MATE base library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Wolfgang Ulbrich <fedora> |
| Component: | Package Review | Assignee: | Dan Mashal <dan.mashal> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan.mashal, marcus.moeller, notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | dan.mashal:
fedora-review-
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-21 11:59:37 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Wolfgang Ulbrich
2012-08-08 14:54:17 UTC
New sources SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/fc17/SPECS/libmate.spec SRPM: http://raveit65.fedorapeople.org/Mate-Desktop/fc17/SRPM/libmate-1.4.0-7.fc17.src.rpm Starting point for review. SPEC: http://raveit65.fedorapeople.org/Mate-Desktop/f19/SPECS/libmate.spec SRPM: http://raveit65.fedorapeople.org/Mate-Desktop/f19/SRPM/libmate-1.4.0-8.fc19.src.rpm From my knowledge, utemper requirenment can be removed safely. You may also want to encourage upstream to fix some licensing issues: libmate-1.4.0/libmate/mate-help.c: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-mateconf.c: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-mateconfP.h: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-url.c: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-mateconf.h: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-help.h: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/libmate/mate-url.h: LGPL (v2 or later) (with incorrect FSF address) libmate-1.4.0/COPYING.LIB: LGPL (v2 or later) (with incorrect FSF address) (In reply to comment #4) > You may also want to encourage upstream to fix some licensing issues: > > libmate-1.4.0/libmate/mate-help.c: LGPL (v2 or later) (with incorrect FSF > address) > libmate-1.4.0/libmate/mate-mateconf.c: LGPL (v2 or later) (with incorrect > FSF address) > libmate-1.4.0/libmate/mate-mateconfP.h: LGPL (v2 or later) (with incorrect > FSF address) > libmate-1.4.0/libmate/mate-url.c: LGPL (v2 or later) (with incorrect FSF > address) > libmate-1.4.0/libmate/mate-mateconf.h: LGPL (v2 or later) (with incorrect > FSF address) > libmate-1.4.0/libmate/mate-help.h: LGPL (v2 or later) (with incorrect FSF > address) > libmate-1.4.0/libmate/mate-url.h: LGPL (v2 or later) (with incorrect FSF > address) > libmate-1.4.0/COPYING.LIB: LGPL (v2 or later) (with incorrect FSF address) done, and it s fixed in upstream https://github.com/mate-desktop/libmate/commit/c8606d44b1b37e34f60611c6790857ab274a9204 Build requires should be as follows:
mate-common
mate-conf-devel
mate-vfs
libmatecomponent-devel
libcanberra-devel
GConf2 (unless we are using mateconf here?)
==============================================================================
Build/install sections should look like this:
%build
%configure -disable-static --disable-schemas --disable-esd
make %{?_smp_mflags} V=1
===========================================================================
Needs to be here for schemas:
%pre
%gconf_schema_prepare *.schemas
===========================================================================
%install
export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1
make DESTDIR=%{buildroot} install
%find_lang %{name}
rm -rf %{buildroot}/%{_libdir}/matecomponent/monikers/*.la
===========================================================================
Please own the proper dirs:
%{_datadir}/gtk-doc/html/libmate/
%{_includedir}/libmate-2.0/
{_datadir}/mate-background-properties/mate-default.xml
sysconfdir should look like this: pretty simple.
Please change %config directive to the following:
%config(noreplace) %{_sysconfdir}/sound/events/mate.soundlist
%config(noreplace) %{_sysconfdir}/sound/events/gtk2-mate-events.soundlist
These should be OK in the main package:
%{_libdir}/matecomponent/monikers/libmoniker_extra_2.so
%{_libdir}/matecomponent/servers/MATE_Moniker_std.server
============================================================================
Please change the following:
%{_bindir}/* to:
%{_bindir}/mate-open
==============================================================================
Belongs in -devel (obviously)
%{_libdir}/pkgconfig/libmate-2.0.pc
======================
http://vicodan.fedorapeople.org/matespec/libmate.spec
Here's a copy of my spec file, (yeah I know it still needs work, but hope it will help you.)
======================================
Also successful koji build on F17 both arches:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4408052
I don't work for the Mate-Desktop project anymore, because i see no basic for working together with Dan Mashal. Will package this manually. |