Bug 846850

Summary:	Review Request: rosa-launcher - application launcher for KDE
Product:	[Fedora] Fedora	Reporter:	Joseph Marrero <jmarrero>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	jmarrero, kevin, notting, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-18 01:25:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997

Description Joseph Marrero 2012-08-08 21:41:05 UTC

Spec URL: https://docs.google.com/folder/d/0B0IbyJGzQiLLOUhDTWJ1dk1EbWM/edit?pli=1&docId=0B0IbyJGzQiLLdmhrYkNETjQxX1E

SRPM URL: https://docs.google.com/folder/d/0B0IbyJGzQiLLOUhDTWJ1dk1EbWM/edit?pli=1&docId=0B0IbyJGzQiLLci14U2lWWmxXZlU

Description: ROSA Desktop Application Launcher, launches applications and provides a search for Applications and Documents, has a Nepomuk interface for file histories and search. (Nepomuk timeframe currently incomplete in this build)

Fedora Account System Username:jmarrero

Successful Koji Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=4370440

This is my first package and I need a sponsor. Mr. Rex Dieter helped create the first package and did various uptreamable patches, I fixed the icon installation and will be fixing and maintaitaiing this package. The Uptream developer has been notified and has received the patches created by Mr. Dieter.

Comment 1 Rex Dieter 2012-08-08 21:59:11 UTC

I can review.

Comment 2 Rex Dieter 2012-08-08 22:09:15 UTC

$ rpmlint rosa-launcher rosa-launcher-0.34.12-3.fc17.src.rpm
rosa-launcher.x86_64: W: no-documentation
rosa-launcher.x86_64: W: no-manual-page-for-binary rosa-launcher
rosa-launcher.src: W: invalid-url Source0: rosa-launcher-0.34.12.tar.gz
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

mostly harmless.

naming: ok

scriptlets: ok

sources:  not ok
1. MUST: please document where one can get the Source0 used in this package.

macros: ok

licensing:ok


please clarify sources url, otherwise, looks good.

Comment 3 Joseph Marrero 2012-08-08 22:45:51 UTC

Added to SPEC file:
Source0:        http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/rosa-launcher/current/SOURCES/%{name}-%{version}.tar.gz

NEW links:
Spec: https://docs.google.com/open?id=0B0IbyJGzQiLLUHVRdWUtd2g2NU0
SRPM: https://docs.google.com/open?id=0B0IbyJGzQiLLeFJKc2U3RUtkYnM

New Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4370580

Comment 4 Rex Dieter 2012-08-08 22:57:55 UTC

thanks, APPROVED.

Comment 5 Joseph Marrero 2012-08-08 23:23:10 UTC

New Package SCM Request
=======================
Package Name: rosa-launcher
Short Description: application launcher for KDE
Owners: jmarrero rdieter
Branches: f17 f18 rawhide
InitialCC: kde-sig

Comment 6 Gwyn Ciesla 2012-08-09 02:14:31 UTC

Git done (by process-git-requests).

Rawhide is automatic, and kde-sig is not a valid fas account.

Comment 7 Fedora Update System 2012-08-09 07:08:52 UTC

rosa-launcher-0.34.12-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/rosa-launcher-0.34.12-5.fc17

Comment 8 Fedora Update System 2012-08-09 22:56:02 UTC

rosa-launcher-0.34.12-5.fc17 has been pushed to the Fedora 17 testing repository.

Comment 9 Fedora Update System 2012-08-18 01:25:10 UTC

rosa-launcher-0.34.12-5.fc17 has been pushed to the Fedora 17 stable repository.