Bug 847120
| Summary: | Unable to build JSS on F17 or newer | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Endi Sukma Dewata <edewata> | ||||||||||||||||||
| Component: | jss | Assignee: | Christina Fu <cfu> | ||||||||||||||||||
| Status: | CLOSED EOL | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||
| Version: | 23 | CC: | cfu, emaldona, gsterlin, jdennis, mharmsen, nkinder, rmeggins | ||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||
| Last Closed: | 2016-12-20 12:17:12 UTC | Type: | Bug | ||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
| Embargoed: | |||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Endi Sukma Dewata
2012-08-09 18:35:41 UTC
This fix won't work because F-17 now has Linux 3.5. The linux version should not be hard-coded as it can be discovered on the fly. This problem may go away or at least be ameliorated one jss updates to the latest release upstream. In the meanttime something needs to be done. Created attachment 614610 [details]
Discovers the Linux major.minor versions on the fly
Yes, piping multiple times with awk is a bit ugly. Until a someone suggests a cleaner solution this is what I have been using to get around this problem.
looks good to me as long as it works. As to whether this is good scripting, I am not the best one to judge. How about run by mharmsen as well? Created attachment 615532 [details]
spec file changes to discover Linux major.minor versions (in patch form)
This is a temporary fix so it builds F-17 and F-18 until jss gets rebased to the latest upstream version. The latest coreconf has become smarter about the newer linux versions. Execute patch -p1 < nameothepatch.patch to apply it. I have tested it on master, f18, f17, and f16.
(In reply to comment #4) > it. I have tested it on master, f18, f17, and f16. As the romans used to say: caveat emptor. This was was mostly tested locally mostly which isn't sufficient. Doing 'fedpkg mockbuild' along with scratch builds is the proper way to test the changes. This message is a reminder that Fedora 17 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 17. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '17'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 17's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 17 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 17's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. *** Bug 985081 has been marked as a duplicate of this bug. *** nkinder suggested that as a short term solution we should use the Linux2.6.mk for all Linux kernels >= 2.6 to match the kernel used by the build system. Created attachment 774954 [details]
0001-Fixed-build-issue-on-F18.patch
Created attachment 774955 [details]
0001-Fixed-build-issue-on-F19.patch
Created attachment 777141 [details]
F18 patch rebuilt for rpmbuild
Using an unpacked 'jss-4.2.6-26.fc18.src.rpm' from Koji, I was unable to apply the 'git-based' patch when using rpmbuild on a Fedora 18 machine, so the patch was recreated using 'diff -rupN'.
Created attachment 777143 [details]
Revised F18 spec file
The spec file in the original patch contained the following errors:
* the following changelog appears to be from Fedora 19 only:
* Wed Dec 12 2012 Stanislav Ochotnicky <sochotnicky> - 4.2.6-27
- Simple rebuild
* version should be '27' instead of '28'
* 'Wed Feb 17' should be 'Wed Jul 17'
Created attachment 777144 [details]
F19 patch rebuilt for rpmbuild
Using an unpacked 'jss-4.2.6-29.fc19.src.rpm' from Koji, I was unable to apply the 'git-based' patch when using rpmbuild on a Fedora 19 machine, so the patch was recreated using 'diff -rupN'.
Created attachment 777145 [details]
Revised F19 spec file
The spec file in the original patch contained the following errors:
* 'Wed Feb 17' should be 'Wed Jul 17'
jss-4.2.6-28.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jss-4.2.6-28.fc18 jss-4.2.6-30.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/jss-4.2.6-30.fc19 jss-4.2.6-28.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. jss-4.2.6-30.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 This message is a reminder that Fedora 23 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 23. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '23'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 23 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed. |