Bug 847502
Summary: | yumex - yum_childtask.py - error | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Flóki Pálsson <flokip> | ||||
Component: | yum-langpacks | Assignee: | Jens Petersen <petersen> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | unspecified | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 17 | CC: | i18n-bugs, james.antill, notting, petersen, tim.lauridsen, usdanskys | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-08-14 09:22:42 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Flóki Pálsson
2012-08-12 11:17:37 UTC
Does yum command lines work ? It looks like a problem in yum-langpacks. what version of yum-langpacks is installed ? Try running 'yumex --noplugins' Ok, this is caused by yum-langpacks-0.3.0-1 from updates-testing a TYPE_CORE plugin should not use registerCommand to register extra command line commands, only TYPE_INTERACTIVE should do that. At least it should catch these kind of exception and not blowup. Coment #1 >Does yum command lines work ? yes >what version of yum-langpacks is installed ? yum-langpacks-0.3.0-1.fc17.noarch >Try running 'yumex --noplugins' Yes. It works. registerCommand is a member of cli.YumBaseCli (the yum cli main class), but don't exist in yum.YumBase (the yum api main class), so the plugin will blow up if any api users there has enabled plugins. solutions: 1. change plugin type to TYPE_INTERACTIVE (most api users only uses TYPE_CORE plugins) 2. check if registerCommand exists ( if hasattr(self._base,'registerCommand'): ) 3. catch the exception raises by the plugin conduit. *** Bug 847555 has been marked as a duplicate of this bug. *** 1. Done. 2/3. - changed to check for registerCommand. Only one plugin in yum-utils does this from a brief check. yum-langpacks-0.3.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/yum-langpacks-0.3.0-2.fc17 Created attachment 604144 [details]
Plugins types using registerCommand
The updated fixes the issue. Checked plugins in yum-utils, all plugin there uses registerCommand is TYPE_INTERACTIVE except versionlock and it has the check for registerCommand is available, so all is safe there. (See attachment) Thanks !! yum-langpacks-0.3.0-2.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. Thanks for the note - given that, I think TYPE_CORE w/checks is more appropriate for yum-langpacks than TYPE_INTERACTIVE. (In reply to comment #11) > Thanks for the note - given that, I think TYPE_CORE w/checks is more > appropriate for yum-langpacks than TYPE_INTERACTIVE. I agree to that too, yum-langpacks does some actions typical for a TYPE_CORE plugin with some addon commands there is more typical TYPE_INTERACTIVE |