Bug 847517
| Summary: | Review Request: php-pear-Net-DNS2 - PHP Resolver library used to communicate with a DNS server | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | notting, package-review, shawn | ||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-09-25 16:33:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2012-08-12 14:36:41 UTC
Minor changes (use php-pear(PEAR) instead of php-pear), so http://rpms.famillecollet.com/SRPMS/php-pear-Net-DNS2-1.2.2-2.remi.src.rpm On our request, upstream now provides LICENSE and tests, so update to 1.2.3 https://github.com/remicollet/remirepo/commit/2f145f1f69d15eadbd555b8b228f0666882c0574 http://rpms.famillecollet.com/SRPMS/php-pear-Net-DNS2-1.2.3-1.remi.src.rpm Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4401290 In %check, I'm assuming "ping -c 1 dns.google.com" is to check whether the build host is connected to a public network and will then run all tests? dns.google.com does not resolve on my machine and may not for other building machines. Perhaps instead use one of the Google Public DNS IP addresses used in the resolver test file since they respond to pings as well? -- 8.8.8.8 or 8.8.4.4 (In reply to comment #3) > In %check, I'm assuming "ping -c 1 dns.google.com" is to check whether the > build host is connected to a public network and will then run all tests? Yes. But it also check that resolver works. So, as still prefer a name rather that an ip (and a server allowing ping) > dns.google.com does not resolve on my machine and may not for other building > machines. Perhaps instead use one of the Google Public DNS IP addresses > used in the resolver test file since they respond to pings as well? -- > 8.8.8.8 or 8.8.4.4 In our case, koji won't run this test. This is the designed behavior. Do you think this is a blocker for the review ? (In reply to comment #4) > (In reply to comment #3) > > In %check, I'm assuming "ping -c 1 dns.google.com" is to check whether the > > build host is connected to a public network and will then run all tests? > > Yes. > But it also check that resolver works. > So, as still prefer a name rather that an ip (and a server allowing ping) But your ping test would check that the build machine's DNS is set up and resolving correctly. As far as I understand the package, it could work regardless of whether the build machine's DNS is set up correctly or not by correctly providing DNS nameserver IP addresses (and the package resolver test uses the Google Public DNS IPs). If you really prefer a DNS name, perhaps use "google.com" instead? I believe this would resolve for more people than "dns.google.com" -- this would match the actual package resolver test as well. > > dns.google.com does not resolve on my machine and may not for other building > > machines. Perhaps instead use one of the Google Public DNS IP addresses > > used in the resolver test file since they respond to pings as well? -- > > 8.8.8.8 or 8.8.4.4 > > In our case, koji won't run this test. This is the designed behavior. > > Do you think this is a blocker for the review ? No, not a blocker ;) Created attachment 612806 [details]
Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09
No blockers. ==== APPROVED ==== Thanks for the review. I will change used DNS after import. New Package SCM Request ======================= Package Name: php-pear-Net-DNS2 Short Description: PHP Resolver library used to communicate with a DNS server Owners: remi Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). php-pear-Net-DNS2-1.2.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-pear-Net-DNS2-1.2.3-1.fc18 php-pear-Net-DNS2-1.2.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-pear-Net-DNS2-1.2.3-1.fc17 php-pear-Net-DNS2-1.2.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pear-Net-DNS2-1.2.3-1.el6 php-pear-Net-DNS2-1.2.3-1.fc18 has been pushed to the Fedora 18 testing repository. php-pear-Net-DNS2-1.2.4-1.fc18 has been pushed to the Fedora 18 stable repository. |