Bug 847538
| Summary: | Review Request: mediawiki119-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Patrick Uiterwijk <puiterwijk> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | gwync, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-05 17:28:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Patrick Uiterwijk
2012-08-12 18:48:08 UTC
I'll review this. Fixecd %files and added COPYING. Spec URL: http://puiterwijk.fedorapeople.org/packages/mediawiki-HTTP302Found/mediawiki119-HTTP302Found.spec SRPM URL: http://puiterwijk.fedorapeople.org/packages/mediawiki-HTTP302Found/mediawiki119-HTTP302Found-2.0.1-2.fc17.src.rpm OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 83a16d4ed5a3f2cab1ffb40b3f0a086d ./HTTP302Found-2.0.tar.gz 83a16d4ed5a3f2cab1ffb40b3f0a086d /HTTP302Found-2.0.tar.gz OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: 2 packages and 0 specfiles checked; 0 errors, 0 warnings. I see no blockers, so this package is APPROVED. New Package SCM Request ======================= Package Name: mediawiki119-HTTP302Found Short Description: Forces an external HTTP 302 redirect instead of internal redirects Owners: puiterwijk Branches: f18 el6 InitialCC: No reason to re-set cvs flag. . . Note that this is "mediawiki119-HTTP302Found" and not "mediawiki-HTTP302Found" :) One is built against/for the mediawiki119 package. ;) Git done (by process-git-requests). <facepalm> ? Jon Ciesla: Thanks for setting it up, I will import it as soon as it allows me to :). And I'm sorry I didn't add that notification to the request comment, I guess that would've prevented annoyance from you. That, or I could, you know, learn to read. :) Hehe, I guess you can, otherwise you wouldn't have noticed it was almost the same name as earlier today. ;) mediawiki119-HTTP302Found-2.0.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/mediawiki119-HTTP302Found-2.0.1-2.el6 mediawiki119-HTTP302Found-2.0.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository. mediawiki119-HTTP302Found-2.0.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository. |