Bug 847742

Taking the review.

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed

Notes:
======

[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
>>>> These patches are OK, but consider please using POM modifying macros
>>>> instead of patch4 (see https://fedoraproject.org/w/index.php?title=User:Akurtakov/JavaPackagingDraftUpdate#Patching_Maven_pom.xml_files )

[x]: Latest version is packaged.
>>>> Version 2.6.0-RC2 was released, but update at your will since it's RC

[!]: SourceX / PatchY prefixed with %{name}.
     Note: Patch5 (05hamcrest12.diff)
>>>> Please, consider renaming this patch, e. g. to jmock-hamcrest12.patch


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Fully versioned dependency in subpackages, if present.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package
     javadoc
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[-]: Large documentation files are in a -doc subpackage, if required.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 1 files have unknown license. Detailed output of
     licensecheck in /home/tradej/reviews/847742-jmock/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[x]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.

Java:
[-]: If source tarball includes bundled jar/class files these need to be
     removed prior to building
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Fully versioned dependency in subpackages, if present.
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: Pom files have correct add_maven_depmap call
     Note: Some add_maven_depmap calls found. Please check if they are correct
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: If package contains pom.xml files install it (including depmaps) even
     when building with ant
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[!]: SourceX / PatchY prefixed with %{name}.
     Note: Patch5 (05hamcrest12.diff)
[x]: SourceX is a working URL.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

Java:
[x]: Package has BuildArch: noarch (if possible)
[x]: Package uses upstream build method (ant/maven/etc.)

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: jmock-2.5.1-1.fc19.noarch.rpm
          jmock-javadoc-2.5.1-1.fc19.noarch.rpm
          jmock-2.5.1-1.fc19.src.rpm
jmock.noarch: W: invalid-url URL: http://www.jmock.org/ <urlopen error [Errno -2] Name or service not known>
jmock-javadoc.noarch: W: invalid-url URL: http://www.jmock.org/ <urlopen error [Errno -2] Name or service not known>
jmock.src: W: invalid-url URL: http://www.jmock.org/ <urlopen error [Errno -2] Name or service not known>
jmock.src: W: invalid-url Source0: jmock-2.5.1-clean-src-svn.tar.gz
3 packages and 0 specfiles checked; 0 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint jmock-javadoc jmock
jmock-javadoc.noarch: W: invalid-url URL: http://www.jmock.org/ <urlopen error [Errno -2] Name or service not known>
jmock.noarch: W: invalid-url URL: http://www.jmock.org/ <urlopen error [Errno -2] Name or service not known>
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'



Requires
--------
jmock-2.5.1-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):
    
    bsh  
    hamcrest12  
    java >= 1:1.6.0
    jpackage-utils  
    junit4  
    objenesis  

jmock-javadoc-2.5.1-1.fc19.noarch.rpm (rpmlib, GLIBC filtered):
    
    jpackage-utils  



Provides
--------
jmock-2.5.1-1.fc19.noarch.rpm:
    
    jmock = 2.5.1-1.fc19
    mvn(org.jmock:jmock) = 2.5.1
    mvn(org.jmock:jmock-junit3) = 2.5.1
    mvn(org.jmock:jmock-junit4) = 2.5.1
    mvn(org.jmock:jmock-legacy) = 2.5.1
    mvn(org.jmock:jmock-parent) = 2.5.1
    mvn(org.jmock:jmock-script) = 2.5.1
    mvn(org.jmock:jmock-tests) = 2.5.1

jmock-javadoc-2.5.1-1.fc19.noarch.rpm:
    
    jmock-javadoc = 2.5.1-1.fc19



MD5-sum check
-------------


Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 847742 -m fedora-rawhide-x86_64

*** APPROVED ***

hi Tomas,
for
>>>> Version 2.6.0-RC2 was released, but update at your will since it's RC
require hamcrest >= 1.3.x, and this one isn't available in rawhide
thanks
regards

New Package SCM Request
=======================
Package Name: jmock
Short Description: Java library for testing code with mock objects
Owners: gil
Branches: f17 f18
InitialCC: java-sig

Git done (by process-git-requests).

jmock-2.5.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/jmock-2.5.1-1.fc18

jmock-2.5.1-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/jmock-2.5.1-1.fc17

jmock-2.5.1-1.fc18 has been pushed to the Fedora 18 testing repository.

jmock-2.5.1-1.fc18 has been pushed to the Fedora 18 stable repository.