Bug 849149

Summary: channel_id and connection_id swapped at connection
Product: Red Hat Enterprise Linux 7 Reporter: Tomas Jamrisko <tjamrisk>
Component: spice-gtkAssignee: Christophe Fergeau <cfergeau>
Status: CLOSED CURRENTRELEASE QA Contact: Desktop QE <desktop-qa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: pvine
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-12-17 17:34:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Connection on main channel showing the wrong behaviour none

Description Tomas Jamrisko 2012-08-17 12:55:32 UTC 
Description of problem:
spice-gtk sends incorrect SpiceLinkMess to server when a channel is established. channel_id and connection_id seem to be swapped which results in server having unusable channel list -- all channels have equal id

Version-Release number of selected component (if applicable):
spice-gtk-0.12-4.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Start capturing packets on your machine 
2. Connect to a spice server
3. Cancel capture
4. Disect the capture with wireshark with spice-disector
5. look for CHANNELS_LIST packet
6. Search for packets with SESSION_ID 
  
Actual results:
in 5. all channels will be reported as having ID: 0
in 6. all channels will have different SESSION_ID instead of Channel ID, even though they should be logically in the same session. 

Expected results:
it should be the other way around



Additional info:
Comment 1 Tomas Jamrisko 2012-08-17 13:00:38 UTC 
Created attachment 605197 [details]
Connection on main channel showing the wrong behaviour

Completely forgot to attach this file. 

Its cut from tshark, shows both SESSION_ID and CHANNEL_ID of main channel, and later there is CHANNEL_LIST packet, which display all channels having the same ID, if required I can add other channels from the session as well (the SESSION_ID is unique for each channel)
Comment 4 Christophe Fergeau 2013-12-17 17:34:34 UTC 
(In reply to Tomas Jamrisko from comment #0)
> Description of problem:
> spice-gtk sends incorrect SpiceLinkMess to server when a channel is
> established. channel_id and connection_id seem to be swapped which results
> in server having unusable channel list -- all channels have equal id
> 
> Version-Release number of selected component (if applicable):
> spice-gtk-0.12-4.el7.x86_64
> 
> How reproducible:
> Always
> 
> Steps to Reproduce:
> 1. Start capturing packets on your machine 
> 2. Connect to a spice server
> 3. Cancel capture
> 4. Disect the capture with wireshark with spice-disector
> 5. look for CHANNELS_LIST packet
> 6. Search for packets with SESSION_ID 
>   
> Actual results:
> in 5. all channels will be reported as having ID: 0
> in 6. all channels will have different SESSION_ID instead of Channel ID,
> even though they should be logically in the same session. 
> 

I just tried this on a RHEL7 client, and 6) is correct, they have the right Channel ID, and Session ID is constant. I could not see a CHANNELS_LIST message so did not check 5).

I'm closing this as CLOSED CURRENTRELEASE, but reopen if you can still reproduce this bug.