Bug 849268

Summary: Missing dependency on nm-connection-editor
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: control-centerAssignee: Control Center Maintainer <control-center-maint>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 18CC: control-center-maint, debarshir, mclasen, mkasik, rstrode
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 862835 (view as bug list) Environment:
Last Closed: 2012-09-27 00:12:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adam Williamson 2012-08-17 22:36:38 UTC 
control-center's Network panel calls nm-connection-editor to edit certain types of connections (I think wireless connections and VPNs):

panels/network/cc-network-panel.c:                cmdline = g_strdup_printf ("nm-connection-editor --create --type %s", type);
panels/network/cc-network-panel.c:                        g_warning ("Failed to launch nm-connection-editor: %s", error->message);
panels/network/net-vpn.c:        cmdline = g_strdup_printf ("nm-connection-editor --edit %s", uuid);
panels/network/net-vpn.c:                g_warning ("Failed to launch nm-connection-editor: %s", error->message);
panels/network/net-device.c:        cmdline = g_strdup_printf ("nm-connection-editor --edit %s", uuid);
panels/network/net-device.c:                g_warning ("Failed to launch nm-connection-editor: %s", error->message);

but our control-center package has no dependency on nm-connection-editor. If you try and configure a VPN connection without it installed, you just get zero feedback (the 'Failed to launch' message is printed only to the console if you ran from a console, I think, there's no graphical error).
Comment 1 Debarshi Ray 2012-08-17 22:46:14 UTC 
commit 9d38f9b3b28fed4251fe45eac87917d2dda0b26d
Author: Debarshi Ray <debarshir>
Date:   Sat Aug 18 00:45:33 2012 +0200

    Add Requires: nm-connection-editor (RH #849268)