Bug 849296
| Summary: | gluster volume delete --xml outputs wrong xml structure | |||
|---|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Vidya Sakar <vinaraya> | |
| Component: | glusterfs | Assignee: | Kaushal <kaushal> | |
| Status: | CLOSED ERRATA | QA Contact: | amainkar | |
| Severity: | high | Docs Contact: | ||
| Priority: | medium | |||
| Version: | 2.0 | CC: | barumuga, gluster-bugs, rfortier, sdharane, vagarwal, vbellur, vraman | |
| Target Milestone: | --- | Keywords: | ZStream | |
| Target Release: | RHGS 2.1.2 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | glusterfs-3.4.0qa8 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | 845510 | |||
| : | 858463 (view as bug list) | Environment: | ||
| Last Closed: | 2014-02-25 07:21:50 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 845510 | |||
| Bug Blocks: | 858463 | |||
|
Description
Vidya Sakar
2012-08-18 02:11:02 UTC
Patch for upstream/master under review at http://review.gluster.org/3869 Fixed by commit f1f3d1c (cli: Changes and enhancements to XML output) for bug https://bugzilla.redhat.com/show_bug.cgi?id=828131 . Reviewed at http://review.gluster.org/3869 . Not yet fixed in version glusterfs 3.3.0rhsvirt1-8.el6rhs, Moving to ASSIGNED fixed only in upstream... available to testing with 3.4.0qa2 release. verified on glusterfs 3.4.0qa5 not working as per excepted xml mentioned above so changing status actual output:- gluster volume delete test --xml Deleting volume will erase all information about the volume. Do you want to continue? (y/n) y <?xml version="1.0" encoding="UTF-8" standalone="yes"?> <cliOutput><opRet>0</opRet><opErrno>115</opErrno><opErrstr></opErrstr><volDelete><volume><name>test</name><id>fc58bdfa-d7f4-41bf-b829-5bf8f35713fb</id></volume></volDelete></cliOutput> I see that there is nothing wrong in the output... why did it fail QA? to see the xml output in a 'pretty' format, try below "gluster volume delete test --xml | xmllint --format -" not related to format in output when there is no value for any tag it should be <tagname/> not <tagname></tagname> in above output - <opErrstr></opErrstr> is not coming properly, that's why. The fix for this under review here http://review.gluster.org/4355 verified on 3.4.0.2rhs-1.el6rhs.x86_64
working as per expected xml mentioned in description, need info before I change status to 'Verified'
1.<opErrno> is always 115. Is this expected behaviour?
2. In case of failure, <volDelete> and all tags under it are not displayed. Is this expected behaviour?
e.g.
[root@cutlass ~]# gluster volume delete 22 --xml
Deleting volume will erase all information about the volume. Do you want to continue? (y/n) y
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>0</opRet>
<opErrno>115</opErrno>
<opErrstr/>
<volDelete>
<volume>
<name>22</name>
<id>fc487e35-179f-49c3-91c5-efdce5525dea</id>
</volume>
</volDelete>
</cliOutput>
[root@cutlass ~]# gluster volume delete 22 --xml
Deleting volume will erase all information about the volume. Do you want to continue? (y/n) y
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput>
<opRet>-1</opRet>
<opErrno>115</opErrno>
<opErrstr>Volume 22 does not exist</opErrstr>
</cliOutput>
Regarding the tags not being shown during error, that is expected. And I believe that's good enough for RHSC team, which is the primary user for xml outputs. Anyway, tagging this as a needinfo from Bala. Bala, Can you give your opinions? Other than that, I'll take a look into the other errors. Reducing priority, as I this isn't something serious. - Kaushal Current xml output resolves this issue. I would prefer this bz to be closed safely. verified with 3.4.0.53rhs-1.el6_4.x86_64 giving xml output in proper format hence moving it to verified Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2014-0208.html |