Bug 849751

Summary: RFE: protect resource tree from direct navigation to a resource with many siblings
Product: [Other] RHQ Project Reporter: Jay Shaughnessy <jshaughn>
Component: Core UIAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: high    
Version: 4.4CC: hrupp
Target Milestone: ---   
Target Release: RHQ 4.5.0   
Hardware: All   
OS: All   
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=847014
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-01 06:17:53 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 849761    

Description Jay Shaughnessy 2012-08-20 14:51:31 EDT
The fix for bug 847014 introduced bounded, predictable expansion for resource tree child nodes.

This means that if a node in a tree (a parent resource) has perhaps thousands of children, that we protect against pulling an unlimited amount of data into the tree.

We have the same issue when a user navigates directly to a resource that may have thousands of siblings (via a link or bookmark).  We need to protect the tree from an unbounded fetch.
Comment 1 Jay Shaughnessy 2012-08-20 15:03:50 EDT
master commit 414ccdf3fd964dc6d64abe511ec02f4e9170aa40

Apply the new ResourceManager.findResourcesByCriteriaBounded() method
to getResourceLineageAndSiblings() in order to similarly bound the initial
tree building fetch.  Currently getResourceLineageAndSiblings() will use
the defaults applied to findResourcesByCriteriaBounded(), although we may
find that providing separate overrides will be useful.


Test Notes:
The initial fetch will no longer be unbounded so it's possible that users that previously did not see any truncation may not see it. But it's unlikely as by default we still pull up to 1000 siblings.

Testing could be easier by setting overrides to smaller numbers (see bug 847014 for more on how to do that) testing may be easier.  In all cases the resource being navigated to should show up in the tree, even if it is at the bottom of many siblings.
Comment 2 Heiko W. Rupp 2013-09-01 06:17:53 EDT
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.