Bug 849859

Summary: Bot should restore the needinfo flag after vendor entered the leverage IDs.
Product: Red Hat Certification Program Reporter: Jianwei Weng <jweng>
Component: Certification Workflow EngineAssignee: Feng Wang <fwang>
Status: CLOSED CURRENTRELEASE QA Contact: Suprith Gangawar <sgangawa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.0CC: hwcert-reviewers, pmao, rlandry
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-30 07:40:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jianwei Weng 2012-08-21 06:29:47 UTC 
https://hardware.redhat.com/show_activity.cgi?id=836295
https://hardware.redhat.com/show_activity.cgi?id=836299

gregg.shick entered some leverage IDs on 2012-08-14,Bot did nothing after that,since the last_update_person is non-reviewer,bot should place a comment there for attention and restore the needinfo flag on reviewer.
Comment 1 Rob Landry 2012-08-21 16:52:33 UTC 
This is actually a catalog bug I think.  Setting needinfo on weishen.
Comment 2 Wei Shen 2012-08-22 00:24:34 UTC 
It can be easier to fix it on hwcertbot side
Comment 3 Rob Landry 2012-08-22 00:25:48 UTC 
but that means there a gap between when the work is entered (process.cgi) and when the work is identified, when hwcertbot goes to reset some flags.
Comment 4 Wei Shen 2012-08-22 00:33:15 UTC 
(In reply to comment #3)
> but that means there a gap between when the work is entered (process.cgi)
> and when the work is identified, when hwcertbot goes to reset some flags.

right, now all changes to hwcert data won't be recorded in bz db and the bot currently depends on bz data, so there is a gap
Comment 5 Rob Landry 2012-08-22 00:44:03 UTC 
Catalog knows about both table sets so it should be able to set the flag when the testplan table changes resolving the gap.
Comment 6 Wei Shen 2012-08-22 00:49:00 UTC 
bot just cares about the last update person, if catalog sets flag on each action, it doesn't make sense
Comment 7 Rob Landry 2012-08-22 01:15:48 UTC 
Is the leverage work flag being properly set when the vendor adds the leverage id's by the catalog?
Comment 8 Wei Shen 2012-08-22 01:30:11 UTC 
(In reply to comment #7)
> Is the leverage work flag being properly set when the vendor adds the
> leverage id's by the catalog?

Yes, it works,but bot doesn't deal with leverage certs without needinfo, which is a bug
Comment 9 Rob Landry 2012-08-22 01:31:39 UTC 
Ah, I see.  Is there any reason why needinfo is required in addition to leverage?  Seems like removing that dependency would be the fix?
Comment 12 Feng Wang 2015-11-30 07:40:01 UTC 
According to reviewers, this is fixed and moved to Done.