Bug 851089
| Summary: | SSL protocol errros in Thunderbird 17 should give feedback to the user | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Kai Engert (:kaie) (inactive account) <kengert> | ||||||||
| Component: | thunderbird | Assignee: | Martin Stransky <stransky> | ||||||||
| Status: | CLOSED WONTFIX | QA Contact: | Desktop QE <desktop-qa-list> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 6.4 | CC: | eparis, jhorak, kengert, rrelyea, stransky | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | [new summary comment 6] | ||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2014-10-20 11:23:17 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Kai Engert (:kaie) (inactive account)
2012-08-23 08:41:32 UTC
Created attachment 606511 [details]
patch v4 (same as attached upstream)
Let's just use a patch that doesn't require further discussions upstream. I've made a patch that uses an embedded, non-localizable english string. That should be sufficient for error logging purposes.
Bob, could you please review?
I'm proposing this patch for Thunderbird; hwoever it's fine to add it to XulRunner/Firefox, too, if package maintainers want it.
FYI, Martin said he is interested to have this patch, and he will manage the patch, once the patch has r+ Yes, we'd like to use this patch for Thunderbird 17 ESR. The r+ would be great. Created attachment 606512 [details]
test addon
This addon can be used for testing purpose.
It will start by loading several documents in the background (invisible).
Have a look at the error console.
With upstream Mozilla, nothing happens.
With patch applied, you should see console messages.
(Set the filter to "messages", not errors, not warnings).
The following is only relevant if addon gets installed into a browser (Firefox):
After 30 seconds, the addon will open several tabs and load pages that will result in errors. This is just for sanity purposes, to ensure our patching doesn't break the messages shown in the error pages. I've already performed the testing on my own, and things look good.
Since I had filed this bug, the situation has changed. Upstream Mozilla added the error console logging to the shared Mozilla 17 code, it will be effective in both Thunderbird 17 and Firefox 17. However, since errors are not discoverable by users (unless they know to search in the error console), the situation is still unsatisfying, and I don't expect a solution for upstream version 17. Because of that, I propose to add a patch to Thunderbird 17 in RHEL that will bring back the error reporting prompts (the patch was rejected upstream). The code to be patched lives in the code that is usually common to both Firefox and Xulrunner. This means, the suggested approach works, only, if Thunderbird builds its own private binary of Gecko. But that appears to be the situation, already. I'm changing the bug description accordingly. The patch v9 was taken from upstream 785426. I propose this approach for any RHEL branch that ships Thunderbird 17. (Should we clone this bug for RHEL 5.x ?) Created attachment 616533 [details]
patch v9 for Mozilla 17
This request was not resolved in time for the current release. Red Hat invites you to ask your support representative to propose this request, if still desired, for consideration in the next release of Red Hat Enterprise Linux. Kai, do you know if we still need this one in Thunderbird, to provide user info about broken certificate? Given that nobody paid attention to this during the previous 2 years, and given that the world has continued to rotate, maybe we can close the bug... |