Bug 851090
| Summary: | Ctrl-Shift composite key not work | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | shendl <shendlkernel> |
| Component: | spice-gtk | Assignee: | Marc-Andre Lureau <marcandre.lureau> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.5 | CC: | acathrow, cfergeau, dblechte, dyasny, marcandre.lureau, mkrcmari |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | spice-gtk-0.14-5.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-21 08:49:00 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Can also be reproduced when setting shortcuts through the controller, or with
diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index def52c5..f6997eb 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -1348,7 +1348,7 @@ virt_viewer_app_constructor (GType gtype,
gtk_accel_map_add_entry("<virt-viewer>/file/smartcard-insert", GDK_F8, GDK_SHIFT_MASK);
gtk_accel_map_add_entry("<virt-viewer>/file/smartcard-remove", GDK_F9, GDK_SHIFT_MASK);
- gtk_accel_map_add_entry("<virt-viewer>/view/fullscreen", GDK_F11, 0);
+ gtk_accel_map_add_entry("<virt-viewer>/view/fullscreen", GDK_F6, GDK_SHIFT_MASK | GDK_CONTROL_MASK);
gtk_accel_map_add_entry("<virt-viewer>/view/release-cursor", GDK_F12, GDK_SHIFT_MASK);
return obj;
< elmarco> teuf: that seems like a gtk accelerator limitation to me
I can't reproduce the issue. However I understand why you get confused. Customizing the gtk accelarator isn't enough, you need to configure the ~/.config/spice/setting [general] grab-sequence=Control_L+Shift_L+F12 gtk correctly handles ctrl+shift+f12 by the change you made, and spice-gtk too if this setting In fact the gtk accelerator isn't really necessary, it is only there as a hint in the menu, but only spice-gtk can handle the ungrab key combination. When the widget doesn't have the grab, spicy will still call ungrab on the widget, but then it is really useless. Unfortunately, spice-gtk key combination notation is different from gtk, so I proposed a patch to remove the menu entry, and also display the correct sequence in the status bar. "Unfortunately, spice-gtk key combination notation is different from gtk, so I proposed a patch to remove the menu entry, and also display the correct sequence in the status bar." patch in spice-gtk-0.14-5.el6 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0343.html |
Description of problem: Ctrl-Shift composite key not work Version-Release number of selected component (if applicable): all How reproducible: edit spicy.c file to edit some accelerator to use Ctrl-Shift-XXX can produce this program. Steps to Reproduce: edit spicy.c file. search " .accelerator = " ,and replace accelerator to <Control><shift>XXX format. Example: replace .accelerator = "<shift>F12", to .accelerator = " <Control><shift>F12", Actual results: If you press ctrl-shift-f12 can activate this action. And you press ctrl-f12 also can activate this action! Expected results: ctrl-shift-f12 can activate this action,and other composite key can't activate this action! Additional info: