Bug 851641

Created attachment 606894 [details]
rpmlint output

Created attachment 606944 [details]
koji output

I can't reach the koji webinteface(page loads forever). I decided to attach the console output instead.

Drop the Requires line. rpmbuild is able to figure that out. qt3-devel would have been wrong anyway.

As far as I can see, this package bundles code from at least Argyll and wxwidgets which is not allowed. Some snapshot of SCons is included as well.

What is Patch0 good for? Please put a comment in the spec file and refer to an upstream ticket, if possible.

Add sRGB_profile_License and KNOWN_BUGS to the doc macro.

"""
%{_datadir}/%{name}/data/pics/*
%{_datadir}/%{name}/data/profiles/*
%{_datadir}/%{name}/data/template/*
"""

Using this syntax, you don't own {_datadir}/%{name}. I'd just replace those three lines with:

{_datadir}/%{name}

Please use the name macro for the patch names. I also suggest to use it for the icon and desktop file.

I personally consider "open source" not worth mentioning and only bloating description and summary, because everything in Fedora is Free Software.

Please inform upstream about the wrong postal address of the FSF. The actual license is GPLv2+, by the way. You can find out easily using "licensecheck".

The build doesn't use Fedora's compiler flags. Using them will also produce a useful debuginfo package.

(In reply to comment #3)

First of all thanks for the feedback.

> Drop the Requires line. rpmbuild is able to figure that out. qt3-devel would
> have been wrong anyway.

If I drop that line, I will get a runtime error complaining about the missing assistant executable(qt-assistant). Yum provides lists qt3-devel as providing package for this file. But there should be a comment in the spec-file.

> As far as I can see, this package bundles code from at least Argyll and
> wxwidgets which is not allowed. Some snapshot of SCons is included as well.

What is a common way to fix this? Best fix would be if upstream could clean the release directory. Is it also a valid fix to remove the components and create a new release archive? Removing the SCons part is trivial, it is not used anyway. Removing wxwidgets and Argyll might be harder.

> What is Patch0 good for? Please put a comment in the spec file and refer to
> an upstream ticket, if possible.

I will file a bug upstream for that. The Patch0 is also included in the Debian package. Without this patch it won't compile, with the error: 'BOOL' does not name a type.

> """
> %{_datadir}/%{name}/data/pics/*
> %{_datadir}/%{name}/data/profiles/*
> %{_datadir}/%{name}/data/template/*
> """
> 
> Using this syntax, you don't own {_datadir}/%{name}. I'd just replace those
> three lines with:
> 
> {_datadir}/%{name}

I did this in the first version, the problem is that %{_datadir}/%{name}/data/translations/ must be excluded because %find_lang takes care of these files. Is it OK to change the line %files -f %{name}.lang to just %files?

> Please use the name macro for the patch names. I also suggest to use it for
> the icon and desktop file.
> 
> I personally consider "open source" not worth mentioning and only bloating
> description and summary, because everything in Fedora is Free Software.

That idea came to me too, after filing this bug. It is the project description on sourceforge :-).

I fixed some of the issues, see http://git.dyroff.org/?p=sdyroff-rpms.git;a=blob;f=SPECS/lprof.spec;h=e1bf7866f1ce2b1ed5ec5ec3636176c8183d095f;hb=0930c823297262b45a85c35a75141d29bb88455b

I think this package won't make it in fedora any time soon. In order to remove the argyll part, which is linked statically, there needs to be a argyllcms-devel package. I think argyll doesn't even build a shared library for the used code.

I will wait until upstream reacts on the filed bug (bool-patch) and then try to discuss this issue with them.

Therefore labelling it "not ready for review"

Lifting FE-NEEDSPONSOR, I'm sponsoring Sebastian.

The lprof project seems to be dead as wood. Maybe we should close this for good.

Go on and close it. We should also remove it from the package whishlist in the wiki.

awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11324994

awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11324998

awd123's scratch build of color-0.0.8-1.src.rpm for f21 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11325006

awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11325010

awd123's scratch build of color-0.0.8-1.src.rpm for f22 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=11325018