Bug 852232
Summary: | Review Request: python-vaporize - library for the Rackspace Cloud | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Bruno <dbruno> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dbruno, mario.blaettermann, notting |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-09-29 17:33:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Daniel Bruno
2012-08-27 23:39:02 UTC
Some typos in the description: libarry > library menas > means Is it intended to go in EPEL 5? Spec URL: http://dbruno.fedorapeople.org/python-vaporize/python-vaporize.spec SRPM URL: http://dbruno.fedorapeople.org/python-vaporize/python-vaporize-0.2.1-3.fc17.src.rpm * The typos were fixed. * At first my intention is to add this package on Fedora repository. Thanks, Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4459965 $ rpmlint -i -v * python-vaporize.src: I: checking python-vaporize.src: W: spelling-error %description -l en_US sendpoints -> endpoints, s endpoints, send points The value of this tag appears to be misspelled. Please double-check. python-vaporize.src: W: spelling-error %description -l en_US libary -> library, millibar The value of this tag appears to be misspelled. Please double-check. python-vaporize.src: W: spelling-error %description -l en_US instantiations -> substantiations, instantiates, instantiate The value of this tag appears to be misspelled. Please double-check. python-vaporize.src: I: checking-url https://github.com/kolanos/vaporize (timeout 10 seconds) python-vaporize.src:20: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 20) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-vaporize.src: I: checking-url http://pypi.python.org/packages/source/v/vaporize/vaporize-0.2.1.tar.gz (timeout 10 seconds) python-vaporize.noarch: I: checking python-vaporize.noarch: W: spelling-error %description -l en_US sendpoints -> endpoints, s endpoints, send points The value of this tag appears to be misspelled. Please double-check. python-vaporize.noarch: W: spelling-error %description -l en_US libary -> library, millibar The value of this tag appears to be misspelled. Please double-check. python-vaporize.noarch: W: spelling-error %description -l en_US instantiations -> substantiations, instantiates, instantiate The value of this tag appears to be misspelled. Please double-check. python-vaporize.noarch: I: checking-url https://github.com/kolanos/vaporize (timeout 10 seconds) python-vaporize.noarch: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. python-vaporize.spec:20: W: mixed-use-of-spaces-and-tabs (spaces: line 7, tab: line 20) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. python-vaporize.spec: I: checking-url http://pypi.python.org/packages/source/v/vaporize/vaporize-0.2.1.tar.gz (timeout 10 seconds) 2 packages and 1 specfiles checked; 0 errors, 9 warnings. The spelling errors are ignoreable, but please keep the lines in %description no longer than 80 characters and remove trailing whitespaces. Don't mix spaces and tabs in your spec. I recommend using spaces generally, this gives an identical view in all text editors, regardless of the configured tab width. An empty line between Requires and %description would be nice, for better readability. The BuildRoot definition, the initial cleaning in %install, the %clean section and %defattr are obsolete for non-EPEL5 packages, please remove them when you import your spec file into Git, or remove them generally if you don't want to provide packages for EPEL 5. Please add < and > around your mail address in %changelog. I don't know if it is mandatory, but the syntax highlighting of my text editor doesn't recognize it as a mail address without them. A README file should be the minimum documentation here. Contact the upstream developer for this issue; for the time being you could create a README file from the contents of PKG-INFO (not the whole file, only the lines from 10 to 75). Please check the first entry in %changelog. There's an upstream version 0.0.0, should be a real version number. Any progress here? Once you have updated the files, I'll take this for a full review. Is this review ticket still alive? If yes, please provide a fixed version, and I will do the review. No response from the reporter for more than a year. I will close it as FE-DEADREVIEW. |