Bug 852486
Summary: | rubygem-stickshift-node is running restorecon against /var/lib/stickshift | ||
---|---|---|---|
Product: | OKD | Reporter: | Thomas Wiest <twiest> |
Component: | Containers | Assignee: | Ram Ranganathan <ramr> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 2.x | CC: | jhou, kraman, mfisher, mpatel, ramr, xtian |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-09-17 21:29:05 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Thomas Wiest
2012-08-28 17:07:13 UTC
@kraman made that fix to add /var/lib/stickshift as part of commit bf9987ce -- not sure what the reason was -- the log says to get devenv running. Krishna? bf9987ce (Krishna Raman 2012-03-07 10:06:02 -0800 123) /sbin/restorecon /var/lib/stickshift || : bf9987ce (Krishna Raman 2012-03-07 10:06:02 -0800 126) /sbin/restorecon /var/lib/stickshift/.httpd.d/ || : Heads up, am going to be removing those 2 lines in the next couple of days -- afaics, its not needed but feel free to holler if you feel otherwise!! Was added for the Origin to fix file permissions. If you remove it, will need to add a restorecon to ss-setup-node script. Ok -- will do that -- remove it from node.spec and add it to the ss-setup-node script. Fixed with pull requests: https://github.com/openshift/li/pull/344 https://github.com/openshift/crankcase/pull/456 Tested on devenv_2119 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts [root@ip-10-190-85-85 ~]# rpm -q rubygem-stickshift-node --scripts postinstall scriptlet (using /bin/sh): echo "/usr/bin/ss-trap-user" >> /etc/shells restorecon -r /var/lib/stickshift # copying this file in the post hook so that this file can be replaced by rhc-node # copy this file only if it doesn't already exist if ! [ -f /etc/stickshift/resource_limits.conf ]; then cp -f /etc/stickshift/resource_limits.template /etc/stickshift/resource_limits.conf fi 2. Run: rpm -q rhc-node --scripts There is no line as: "restorecon -r /var/lib/stickshift" Since reproduced the problem, assign it back Good catch Hou. So Thomas, looks like it was being done a couple of times. Ugg, we seem to have these scattered across the place ... One more fix in pull request: https://github.com/openshift/crankcase/pull/460 Move it to ON_QA since https://github.com/openshift/crankcase/pull/460 is merged Verified on devenv_2132 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts 2. Run: rpm -q rhc-node --scripts Result: There is no line as: "restorecon -r /var/lib/stickshift" Verified on devenv_2140 Steps: 1. Run: rpm -q rubygem-stickshift-node --scripts postinstall scriptlet (using /bin/sh): echo "/usr/bin/ss-trap-user" >> /etc/shells # copying this file in the post hook so that this file can be replaced by rhc-node # copy this file only if it doesn't already exist if ! [ -f /etc/stickshift/resource_limits.conf ]; then cp -f /etc/stickshift/resource_limits.template /etc/stickshift/resource_limits.conf fi 2. Run: rpm -q rhc-node --scripts No restorecon against /var/lib/stickshift There is no line as: "restorecon -r /var/lib/stickshift" So move this bug to verified. |