Bug 852625

Summary:	[REST-API] Error 500 on str to UUID conversion failure
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Michael Pasternak <mpastern>
Component:	ovirt-engine-restapi	Assignee:	Ori Liel <oliel>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Elena <edolinin>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	bazulay, dyasny, ecohen, iheim, mpastern, Rhev-m-bugs, sgrinber, srevivo, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	si18	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-04 19:59:32 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Pasternak 2012-08-29 07:08:16 UTC

Description of problem:

Error 500 on str to UUID conversion failure, when user supply
inconvertible string,  server reply with:

status: 500
reason: Internal Server Error
detail: HTTP Status 500


Expected results:

status: 400
reason: Bad Request
detail: xxx cannot be converted to UUID

Comment 1 Ori Liel 2012-08-29 07:53:35 UTC

can you give the exact uml to reproduce? 

Becuase, for example: 

  .../api/vms/!@#!@#!@#

works well and returns 404

Comment 2 Michael Pasternak 2012-08-29 08:07:54 UTC

not in url ori, but in the entity:

DELETE /api/storagedomains/xxx

<storage_domain>
 <host id="!@#!@#!@#">
</storage_domain>

Comment 3 Ori Liel 2012-08-30 11:24:56 UTC

patch posted, http://gerrit.ovirt.org/#/c/7603/

Comment 4 Ori Liel 2012-09-05 11:38:29 UTC

merged upstream, 

  commit c5665533dcf31d74bd7a7fccacd9086e4d487b7e

patch posted downstream: 

  https://gerrit.eng.lab.tlv.redhat.com/#/c/1847 
(awaiting approval)

Comment 5 Ori Liel 2012-09-06 13:24:11 UTC

merged downstream:

  commit efc5b7e2f1e8bb3f13702923865d0bb557729b8c

Comment 6 Elena 2012-09-16 05:58:49 UTC

Verified in si18