Bug 852675

Summary:	[Graphical framebuffer] update device with connected parameter "fail", guest's xml changed
Product:	Red Hat Enterprise Linux 6	Reporter:	Xu Wang <xuwan>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.4	CC:	acathrow, dyasny, dyuan, mjenner, mzhan, whuang
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-0.10.2-0rc1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 07:22:33 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xu Wang 2012-08-29 09:23:06 UTC

Description of problem:
After updated device with connected parameter "fail", guest's xml changed

Version-Release number of selected component (if applicable):
libvirt-0.10.0-0rc1.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Edit graphics element of guest's xml like this:
#virsh dumpxml test --security-info
<graphics type='spice' autoport='yes' listen='0.0.0.0' passwd= 'aaabbb' connected= 'disconnect'>
<listen type='address' address='0.0.0.0'/>
</graphics>

2.Start the guest
#virsh start test

3.Prepare a xml file to update device like this:
#cat spice-new.xml 
<graphics type='spice' port='5900' tlsPort='5901' autoport='yes' listen='0.0.0.0' passwd= 'cccddd' connected= 'fail'/>

4.Open a virt-viewer window and enter the password
#virt-viewer test
password "aaabbb" works.

5.Update device with the xml file and there will be errors
#virsh update-device test spice-new.xml 
error: Failed to update device from spice-new.xml
error: internal error unable to execute QEMU command '__com.redhat_set_password': Could not set password

6.Check the guest's xml
#virsh dumpxml test --security-info
<graphics type='spice' port='5900' autoport='yes' listen='0.0.0.0' passwd= 'cccddd' connected= 'fail'>
<listen type='address' address='0.0.0.0'/>
</graphics>

7.Close the virt-viewer window and reopen it
#virt-viewer test
password "aaabbb" still works not "cccddd".
  
Actual results:
At step 6, the guest's xml changed.

Expected results:
At step 6, the guest's xml shouldn't change.

Additional info:

Comment 3 Xu Wang 2012-08-29 10:24:29 UTC

Also reproduced with libvirt-0.10.0-1.el6.x86_64

Comment 4 Peter Krempa 2012-09-04 08:26:19 UTC

Fixed upstream:

commit 00b81636c557c01e808b5abf2f1ae26295804c60
Author: Peter Krempa <pkrempa>
Date:   Mon Sep 3 16:52:27 2012 +0200

    qemu: Don't update graphic definitions on password change failure
    
    When the password change failed we updated the graphic definition
    anyways, which is not desired.

Comment 6 Xu Wang 2012-09-19 08:57:04 UTC

Reproduce with  libvirt-0.10.0-1.el6.x86_64.

Verified with the package:
libvirt-0.10.2-0rc1.el6.x86_64

Test steps:
1.Edit graphics element of guest's xml like this:
#virsh dumpxml test --security-info
<graphics type='spice' autoport='yes' listen='0.0.0.0' passwd= 'aaabbb' connected= 'disconnect'>
<listen type='address' address='0.0.0.0'/>
</graphics>

2.Start the guest
#virsh start test

3.Prepare a xml file to update device like this:
#cat spice-new.xml 
<graphics type='spice' port='5900' tlsPort='5901' autoport='yes' listen='0.0.0.0' passwd= 'cccddd' connected= 'fail'/>

4.Open a virt-viewer window and enter the password
#virt-viewer test
password "aaabbb" works.

5.Update device with the xml file and there will be errors
#virsh update-device test spice-new.xml 
error: Failed to update device from spice-new.xml
error: internal error unable to execute QEMU command '__com.redhat_set_password': Could not set password

6.Check the guest's xml
#virsh dumpxml test --security-info
<graphics type='spice' autoport='yes' listen='0.0.0.0' passwd= 'aaabbb' connected= 'disconnect'>
<listen type='address' address='0.0.0.0'/>
</graphics>

7.Close the virt-viewer window and reopen it
#virt-viewer test
password "aaabbb" works not "cccddd".

Test results:
Guest 's xml didn't change.
Current command works well.

Comment 8 errata-xmlrpc 2013-02-21 07:22:33 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html