Bug 853340

Summary: [RHEVM][backend] [Host Networking] DC/CL 3.0 Save Network Configuration button is not enabled properly for 3.0 hosts
Product: Red Hat Enterprise Virtualization Manager Reporter: Martin Pavlik <mpavlik>
Component: ovirt-engineAssignee: lpeer <lpeer>
Status: CLOSED WONTFIX QA Contact: Martin Pavlik <mpavlik>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: dyasny, gklein, iheim, lpeer, Rhev-m-bugs, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-02 07:56:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
vdsm.log + engine.log none

Description Martin Pavlik 2012-08-31 07:09:13 UTC 
Created attachment 608408 [details]
vdsm.log + engine.log

This bug raised from https://bugzilla.redhat.com/show_bug.cgi?id=850857 where GUI part of the issue was fixed, now there is a problem with backend

Description of problem:

DC/CL 3.0 Save Network Configuration button is not enabled properly for 3.0 hosts

The "Save network configuration" is enabled according to the "NetConfigDirty" flag, reported by the vdsm.

In 3.0 hosts the flag was reported on vdsStats.
In 3.1 hosts the flag is reported on both vdsStats and vdsCaps.

It seems that the backend reads the flag from the vdsCaps- so there is no backward compatability to 3.0 hosts.


Version-Release number of selected component (if applicable):
DC/CL 3.0 Save Network Configuration button is not enabled properly for 3.0 hosts

How reproducible:
100%

Steps to Reproduce:
Steps to Reproduce:
1. Add host (with 3.0 vdsm) to cluster 3.0
2. Create logical network
3. Hosts -> your host (in maintenance) -> Network interfaces -> some free NIC -> 
 add/edit -> Boot Protocol: static (fill in valid IP/mask) -> do NOT check Save network Configuration -> click OK  (see screenshots)

  
Actual results:
Save Network Configuration button is NOT enabled

Expected results:
Save Network Configuration button IS enabled

Additional info:
Comment 1 lpeer 2012-09-02 07:56:56 UTC 
3.0 hosts did not report the NetConfigDirty in getCaps (only in stats) so the engine should not read this property in getVdsCaps. 

If the host is in maintenance then statistics are not being collected, the save configuration button won't be updated.

This was fixed in 3.1 hosts, so in cluster 3.1 this should not happen.