Bug 853702

Summary: Ovirt SDK: Can't add correlation id to update and delete template nic
Product: Red Hat Enterprise Virtualization Manager Reporter: Avi Tal <atal>
Component: ovirt-engine-restapiAssignee: Ori Liel <oliel>
Status: CLOSED CURRENTRELEASE QA Contact: Yaniv Kaul <ykaul>
Severity: high Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: dyasny, ecohen, iheim, jkt, mkenneth, mpastern, Rhev-m-bugs, srevivo, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network, infra
Fixed In Version: si18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-04 20:02:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Avi Tal 2012-09-02 09:09:58 UTC 
Got the following ERROR after adding correlation_id to update or remove template nic:

TypeError: update() got an unexpected keyword argument 'correlation_id'
or
TypeError: delete() got an unexpected keyword argument 'correlation_id'
Comment 1 Michael Pasternak 2012-09-02 09:16:44 UTC 
Ori, please go over all relevant CI items in RSDL and make sure
they are really have correlation_id header according to metadata 
you have added.
Comment 2 Ori Liel 2012-09-02 13:42:12 UTC 
Looks like more than just correlation-id probelm, the sigantures: 

- name: /api/templates/{template:id}/nics/{nic:id}|rel=delete
- name: /api/templates/{template:id}/nics/{nic:id}|rel=update

were completely missing from .yaml metadata file. 

patch posted upstream, http://gerrit.ovirt.org/#/c/7676/
Comment 3 Ori Liel 2012-09-05 11:35:51 UTC 
patch posted upstream (http://gerrit.ovirt.org/#/c/7676) and merged: 

  commit 9279ee30b42cab7202dc7a43326fb9c1367f4cd2

patch posted downstream: https://gerrit.eng.lab.tlv.redhat.com/#/c/1848/   (awaiting approval)
Comment 4 Ori Liel 2012-09-06 13:23:05 UTC 
merged downstream, 

  commit 5c7cc9e46e98d1679e213be359d2eb872e564078
Comment 5 Avi Tal 2012-09-19 09:09:07 UTC 
Verify on SI18 - PASS