Bug 853704

(In reply to comment #0)
> Created attachment 609038 [details]
> log
> 
> Description of problem:
> 
> when we try to put SPM host and master SD in maintenance at the same time we
> are getting CanDoAction: "Same Action in Progress" from locking mechanism. 
> 
> 2012-09-02 12:15:43,521 WARN 
> [org.ovirt.engine.core.bll.storage.DeactivateStorageDomainCommand]
> (ajp-/127.0.0.1:8009-4) CanDoAction of action DeactivateStorageDomain
> failed. R
> easons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__DEACTIVATE,
> ACTION_TYPE_FAILED_OBJECT_LOCKED
> 
> 
> Version-Release number of selected component (if applicable):
> 
> si16
> 
> How reproducible:
> 
> 100%
> 
> Steps to Reproduce:
> 1. in two hosts cluster with multiple domains -> put spm + master domain in
> maintenance at the same time. 
> 2.
> 3.
>   
> Actual results:
> 
> we are failing on lock with CanDoAction: 
> 2012-09-02 12:15:43,521 WARN 
> [org.ovirt.engine.core.bll.storage.DeactivateStorageDomainCommand]
> (ajp-/127.0.0.1:8009-4) CanDoAction of action DeactivateStorageDomain
> failed. R
> easons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__DEACTIVATE,
> ACTION_TYPE_FAILED_OBJECT_LOCKED
> 
> 
> Expected results:
> 
> since spm recontending and master domain reconstruct are not the same
> actions we should have a different canDoAction. 
> 
> Additional info:backend log

This is not reconstruct, but in any event the error is wrong in general.

This is in CommandBase.java:

log.infoFormat("Failed to Acquire Lock to object {0}", lock);                    addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED);

(In reply to comment #1)
> (In reply to comment #0)
> > Created attachment 609038 [details]
> > log
> > 
> > Description of problem:
> > 
> > when we try to put SPM host and master SD in maintenance at the same time we
> > are getting CanDoAction: "Same Action in Progress" from locking mechanism. 
> > 
> > 2012-09-02 12:15:43,521 WARN 
> > [org.ovirt.engine.core.bll.storage.DeactivateStorageDomainCommand]
> > (ajp-/127.0.0.1:8009-4) CanDoAction of action DeactivateStorageDomain
> > failed. R
> > easons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__DEACTIVATE,
> > ACTION_TYPE_FAILED_OBJECT_LOCKED
> > 
> > 
> > Version-Release number of selected component (if applicable):
> > 
> > si16
> > 
> > How reproducible:
> > 
> > 100%
> > 
> > Steps to Reproduce:
> > 1. in two hosts cluster with multiple domains -> put spm + master domain in
> > maintenance at the same time. 
> > 2.
> > 3.
> >   
> > Actual results:
> > 
> > we are failing on lock with CanDoAction: 
> > 2012-09-02 12:15:43,521 WARN 
> > [org.ovirt.engine.core.bll.storage.DeactivateStorageDomainCommand]
> > (ajp-/127.0.0.1:8009-4) CanDoAction of action DeactivateStorageDomain
> > failed. R
> > easons:VAR__TYPE__STORAGE__DOMAIN,VAR__ACTION__DEACTIVATE,
> > ACTION_TYPE_FAILED_OBJECT_LOCKED
> > 
> > 
> > Expected results:
> > 
> > since spm recontending and master domain reconstruct are not the same
> > actions we should have a different canDoAction. 
> > 
> > Additional info:backend log
> 
> This is not reconstruct, but in any event the error is wrong in general.
> 
> This is in CommandBase.java:
> 
> log.infoFormat("Failed to Acquire Lock to object {0}", lock);               
> addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED);

ACTION_TYPE_FAILED_OBJECT_LOCKED is mapped to the following message:

Cannot ${action} ${type}. Same action in progress.

Maybe we should change it to:

Cannot ${action} ${type}. Related operation is currently on progress. Please try again later.
Other suggestions are welcome.

Ayal - any thoghts about that?

Posted patch:
http://gerrit.ovirt.org/8166

Commit: be6f6fcc8a5df1d3c6ab1f07b91dfef6bc448bcc

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=be6f6fcc8a5df1d3c6ab1f07b91dfef6bc448bcc

si19. fixed. getting the following message:

"Error while executing action: Cannot maintenance Host. Related operation is currently in progress. Please try again later."