Bug 8540

Summary: some words about packaging
Product: [Retired] Red Hat Raw Hide Reporter: pavel.janik
Component: emacsAssignee: Cristian Gafton <gafton>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 1.0CC: pavel.janik
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2000-02-16 23:21:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description pavel.janik 2000-01-17 17:15:35 UTC
Hello,

just got to check Rawhide's emacs package, so:

1. - Prereq: /sbin/install-info is needed to have info pages correctly
installed

2. PUREDEF and XPUREDEF are empty so I propose to remove them

3. Why si libtoolize called?

4. shouldn't be optimalization left out for -nox too?

5. there is something like this in spec:-)

#Build binary with X support
[ -d build-withx ] && rm -rf build-withx
mkdir build-withx && cd build-withx
CFLAGS="$RPM_OPT_FLAGS $XPUREDEF" LDFLAGS=-s \
CFLAGS="$XPUREDEF" LDFLAGS=-s \
  ../configure ${CONFOPTS} --with-x-toolkit ${RPM_ARCH}-redhat-linux-gnu
make
cd ..

I do not think that both CFLAGS and LDFLAGS should be used :-))

6. /usr/lib/emacs/site-lisp should be removed - we have
/usr/share/emacs/site-lisp

7. LDFLAGS=-s is used so any strip does not have reason...

8. recompilation of patched mh-utils.el should be added

9. I propose also updating gnus to newer version because it is terrible to
distribute (in Emacs, not in RH) old version of main news and mail client.

10. site-lisp directories do not contain subdirs.el files

I think this is everything. Plese keep me informed about changes you agree
with. Thank you.

Comment 1 pavel.janik 2000-01-17 17:52:59 UTC
I'm just uploading emacs-20.5a-3.src.rpm to incoming.redhat.com with all of
these things fixed.

Comment 2 Cristian Gafton 2000-02-16 18:00:59 UTC
1. you're right, fixed.

2. they're not empty anymore

3. because we need to pull in the latest config.guess for weird architectures.

4. optimization is on for everybody now

5. doh. that was dumb, fixed.

6. not really - emacs still likes toi check every once in a while. dunno why.

7. you're right

8. done (I think)

9. I'd rather not go there and start updating random packages within emacs

10. done again (I think)

Comment 3 Cristian Gafton 2000-02-16 18:02:59 UTC
Can you mail me a diff for your spec file? incoming.redhat.com is a mess now and
your package update was messed up.

Comment 4 Cristian Gafton 2000-02-16 18:04:59 UTC
*** Bug 7479 has been marked as a duplicate of this bug. ***

Comment 5 pavel.janik 2000-02-16 18:14:59 UTC
Where is it fixed? In emacs-20.5-5 in Rawhide? I will send you the diff tomorrow
because I do not have it here.

Comment 6 Cristian Gafton 2000-02-16 23:21:59 UTC
rawhide will be updated at the end of the week.

Comment 7 pavel.janik 2000-02-21 14:22:59 UTC
it is not :-( Can you send me the package via mail? Thank you.