Bug 854077 (cputemp)

Created attachment 609495 [details]
cputemp SPEC

Hi scott, do you already have a packager account ?

No, but I do have a FAS account: vwbusguy

Some hints (I've not tried to build/test this):


* The following page explains how you can request web storage where to offer your src.rpm and spec file during the review process:

   https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

The page also mentions how to do a scratch build in the Fedora build system.

Also on the page, in the "Make a package" section, is a pointer at the Review Guidelines. It is highly recommended to take a look at them

   https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

and give "rpmlint" (a MUST item on that page) a try. Run "rpmlint -i" on your src.rpm and the built packages. Fix as much as sounds plausible and can be verified via the packaging guidelines. Some of what it reports are false positives, however. ;)


> License:        GPLv3

That doesn't match the source code file, which contains a "GPLv2+" preamble.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Clarification


> Source0:        cputemp-%{version}.tar.gz

https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net


> BuildArch:      noarch
> BuildRequires:  python-devel

It doesn't need the stuff in python-devel, but "BuildRequires: python", does it?


> %build
> # Remove CFLAGS=... for noarch packages (unneeded)
> # CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build
> #./Setup.py --binprefix=%{_prefix}

It's better to remove lines if they are not needed at all. rpmlint gives help about this, too.


> mkdir -p $RPM_BUILD_ROOT%{_datarootdir}/doc/cputemp

Interesting to encounter %_datarootdir once more after a very long time. Thousands of packages use the shorter %{_datadir} instead. Also notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros


> cp cputemp-%{version}\ Change\ Log $RPM_BUILD_ROOT%{_datarootdir}/doc/cputemp

https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps


> mv CPUTemp.py cputemp
> mv cputemp $RPM_BUILD_ROOT/%{_bindir}/cputemp

Even if this is just a tiny package, please don't get used to deleting/moving files in the builddir, because that breaks rpmbuild's --short-circuit options. Prefer copying/installing files to their target location. If you ever co-maintain a larger package with a more complex %files section, you might meet a co-maintainer who will want to do a --short-circuit install to check the installed %files.


> %files
> "%{_datarootdir}/doc/cputemp/cputemp-%{version} Change Log"

Directory /usr/share/doc/cputemp would not be included:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories

I'm going to voluntarily close this out.  This tool has pretty much served my purposes and I don't intend to actively develop or maintain it any more unless there's some revival of interest.  I'm going to work on my other projects instead.

Thanks very much for looking at this Michael.

Scott