Bug 854333
| Summary: | Review Request: python-transifex - Python API to transifex | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luis Bazan <bazanluis20> | ||||||
| Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | a.badger, gwync, notting, package-review, pingou | ||||||
| Target Milestone: | --- | Flags: | a.badger:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-09-18 20:03:25 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Luis Bazan
2012-09-04 16:34:55 UTC
bf44d13a26c6b7f8fb4da7defae3c82c41d6163c4acb2bf23fe7fc9ceec5a5fa python-transifex-0.1.5.tar.gz
Good:
* Named according to the guidelines
* License is BSD in spec and source
* spec file is legible
* Source matches upstream
* No locale files
* Not an elf library
* No bundled libraries
* Not relocatable
* Macros used consistently
* Code, not content
* No large docs
* %doc does not affect package runtime
* Not a gui app
* All filenames are UTF-8
Needswork:
* Please ask upstream to provide a license file in their next tarball. Then we
can include it in our rpms
* The tests are not being run by python setup.py test. Use this instead:
%check
python -m unittest 'transifex.tests.api'
* When run, the unittests have two errors having to do with InvalidSlugs. It
looks like the upstream code changed to use a different exception and forgot
to update their unittests. I'll attach a patch for that
* python-requests is needed at both buildtime (for unittests) and runtime. So you need a
Requires: python-requests
* Incorrect requirements in upstream code:
* python-mock is in upstream's requirements.txt and gets turned into an egg
dependency because the setup.py reads requirements.txt into the setup.py
install_requires section.. Egg dependencies would be checked anytime
someone uses the module with setuptools. Usually that means you should add
it as a package Requires: However, in this case, it looks like python-mock
is not needed at runtime -- only for unittests.
* fabric is in the requirements.txt as well however it's not used in the
distributed tarball.
* According to the python-pip developers, requirements.txt and setup.py
should keep their requirements separate. I've filed a bug upstream:
https://github.com/jakul/python-transifex/issues/2
I'll attach the patch here.
* The transifex/tests/ directory only has buildtime unittests. Not needed in
the completed package. In %install you can do:
rm -rf %{buildroot}%{python-sitelib}/transifex/tests
Cosmetic:
* The Summary does not need to begin with "A". You can change it to "Python API to transifex"
TODO
* rpmlint
* builds in koji
* Package owns all directories it creates and nothing more
* Permissions set properly
@Stanislav: Is this a review that you want to do? I'm happy to leave it to you once I upload these patches or I can continue. Created attachment 609763 [details]
Fix runtime requirements
Created attachment 609764 [details] Fix unittests for change in slug exceptions Submitted upstream: https://github.com/jakul/python-transifex/pull/4 @Toshio, I believe Stanislav is assigned to this review as it assigned to the wrong component. Fixing this. @Luis I let you adjust the name of the review to fit the usual template. New Spec: http://lbazan.fedorapeople.org/python-transifex.spec SRPM: http://lbazan.fedorapeople.org/python-transifex-0.1.5-2.fc17.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4454188 $ rpmlint -v python-transifex.spec python-transifex.spec: I: checking-url http://pypi.python.org/packages/source/p/python-transifex/python-transifex-0.1.5.tar.gz (timeout 10 seconds) 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4461063 SPEC: http://lbazan.fedorapeople.org/python-transifex.spec SRPM: http://lbazan.fedorapeople.org/python-transifex-0.1.6-1.fc17.src.rpm The developer push new release 0.1.6 and this release fix the problem in comment 3 and comment 4 Regards!! Tks Toshio :) 7282dfe87b0bdddcc9deeb4a94ae24e9f7755a7315ab28d7f1e894d8e706bdcf python-transifex-0.1.6.tar.gz
Good:
* New source matches with upstream
* Summary taken care of
* unittests now being run
* unittest failures are fixed
* fabric dep removed
* extraneous python-mock and fabric deps fixed upstream
* builds in koji
* Permissions on directories are fine
* Package owns directories it creates and none created by other packages
* rpmlint clean:
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
NEEDSWORK:
* To delete the tests for the rpm package, you have to run the rm -rf %{buildroot}%{python-sitelib}/transifex/tests after the tests directory is installed by python setup.py install.
* Still need a Requires: for python-request
SPEC: http://lbazan.fedorapeople.org/python-transifex.spec SRPM: http://lbazan.fedorapeople.org/python-transifex-0.1.6-2.fc17.src.rpm Add Requires: python-requests and change rm -rf tests fix RPM BUIL ROOT to buildroot and fix date in changelog APPROVED * All remaining problems have been fixed. Congratulations! New Package SCM Request ======================= Package Name: python-transifex Short Description: Python API to transifex Owners: lbazan Branches: f17 el6 InitialCC: Git done (by process-git-requests). Whoops, please submit a Package Change Request for f18. New Package SCM Request ======================= Package Name: python-transifex Short Description: Python API to transifex Owners: lbazan Branches: f18 f17 el6 InitialCC: See: https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages Do that, for just f18, and re-set cvs to ?. Package Change Request ====================== Package Name: python-transifex New Branches: f18 Owners: lbazan InitialCC: [package request for f18] Git done (by process-git-requests). Perfect, thanks! Best Regards!! python-transifex-0.1.6-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/FEDORA-2012-14084/python-transifex-0.1.6-2.fc17 python-transifex-0.1.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/FEDORA-2012-13869/python-transifex-0.1.6-2.fc18 python-transifex-0.1.6-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-12881/python-transifex-0.1.6-2.el6 python-transifex-0.1.6-2.fc18 has been pushed to the Fedora 18 stable repository. python-transifex-0.1.6-2.fc17 has been pushed to the Fedora 17 stable repository. |