Bug 854386
| Summary: | Review Request: rubygem-openstack-quantum-client - Ruby openstack quantum Client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alejandro_Perez <alejandro.perez.torres> |
| Component: | Package Review | Assignee: | Guillermo Gómez <guillermo.gomez> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | guillermo.gomez, notting, package-review |
| Target Milestone: | --- | Flags: | guillermo.gomez:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-05 07:00:30 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Alejandro_Perez
2012-09-04 21:05:58 UTC
rpmlint output: rpmlint SPECS/rubygem-openstack-quantum-client.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-1.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-openstack-quantum-client-0.1.5-1.fc17.noarch.rpm rubygem-openstack-quantum-client.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. I'll review. 1) Unneeded macros, those are provided by rubygems-devel, remove please.
%global gem_dir /usr/share/rubygems
%global gem_instdir %{gem_dir}/gems/%{gem_name}-%{version}
%global gem_docdir %{gem_dir}/doc/%{gem_name}-%{version}
%global gem_libdir %{gem_instdir}/lib
also, they point to wrong locations for the files.
2) Source0: https://rubygems.org/downloads/openstack-quantum-client-0.1.5.gem
Please use macros for name and version, sample:
Source0: http://rubygems.org/downloads/%{gem_name}-%{version}.gem
3) BuildArch tag repeated in main pkg and doc subpkg. doc subpkg inherits the tag from main declaration. Remove the latest BuildArch tag please.
Hum I had take out unneeded macros, vefore you start the review forgot tu update the srpm on the link. Sorry on that. Do we have new spec and srpm available? Yes here it is http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1.5-2.fc17.src.rpm rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-2.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Ruby:
[!]: Specfile should use macros from rubygem-devel package.
Note: The specfile doesn't use these macros: %doc %{gem_docdir}
%files doc
%doc %{gem_instdir}/README.markdown
%doc %{gem_dir}/doc << please use rubygem-devel package macros for this.
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
Diff spec file in url and in SRPM
---------------------------------
--- /home/gomix/Fedpkg/fedora-review/854386-rubygem-openstack-quantum-client/srpm/rubygem-openstack-quantum-client.spec 2012-10-26 06:16:54.135068777 -0430
+++ /home/gomix/Fedpkg/fedora-review/854386-rubygem-openstack-quantum-client/srpm-unpacked/rubygem-openstack-quantum-client.spec 2012-10-26 06:16:56.549061667 -0430
@@ -2,5 +2,5 @@
Name: rubygem-%{gem_name}
Version: 0.1.5
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: The main objective of this gem is to deal easily with openstack quantum
Heads up, this a false positive BUT, just to make the reviewer life happier, always include both links, srpm and spec (fedora-review has detected the old one in bz).
[?]: Empty changelog entry for version 0.1.5-2 ?
%changelog
* Sun Oct 15 2012 Alejandro Pérez <aeperezt> - 0.1.5-2
* Sun Sep 02 2012 Alejandro Pérez <aeperezt> - 0.1.5-1
- Initial package
Thanks for the notice. it has been done. http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client.spec http://aeperezt.fedorapeople.org/rpmdev/rubygem-openstack-quantum-client-0.1.5-3.fc17.src.rpm rpmlint SPECS/rubygem-openstack-quantum-client.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint SRPMS/rubygem-openstack-quantum-client-0.1.5-3.fc17.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint RPMS/noarch/rubygem-openstack-quantum-client-0.1.5-3.fc17.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Thanks Reviewed, nothing else to comment. APPROVED New Package SCM Request ======================= Package Name: rubygem-openstack-quantum-client Short Description: Ruby Openstack Quantum Interface Owners: aeperezt Branches: f18 f17 el6 InitialCC: Git done (by process-git-requests). rubygem-openstack-quantum-client-0.1.5-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-openstack-quantum-client-0.1.5-3.fc18 rubygem-openstack-quantum-client-0.1.5-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-openstack-quantum-client-0.1.5-3.fc17 Package rubygem-openstack-quantum-client-0.1.5-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing rubygem-openstack-quantum-client-0.1.5-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-18872/rubygem-openstack-quantum-client-0.1.5-3.fc18 then log in and leave karma (feedback). rubygem-openstack-quantum-client-0.1.5-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. rubygem-openstack-quantum-client-0.1.5-3.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |