Bug 854429

Summary:	Deprecated man page and help info for rhc sshkey
Product:	OKD	Reporter:	Jianwei Hou <jhou>
Component:	oc	Assignee:	Hiro Asari <hasari>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.x	CC:	hasari, jizhao, jkeck, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-09-17 21:28:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jianwei Hou 2012-09-05 02:58:16 UTC

Description of problem:
'rhc sshkey update' command is deprecated in US2600, but the 'update' command is not removed from man page and help.

Version-Release number of selected component (if applicable):
fork_ami_US2600_71

How reproducible:
Always

Steps to Reproduce:
1. Simply run rhc sshky --help, man rhc-sshkey, rhc sshkey update --help
2.
3.
  
Actual results:
the 'update' command still exists in man page and help

[root@ip-10-111-7-229 .ssh]# rhc sshkey --help
Usage: rhc sshkey <action>

Manage multiple keys for the registered rhcloud user.

List of Actions
  remove             Remove SSH key from the user account
  list               Display all the SSH keys for the user account
  add                Add SSH key to the user account
  update             Update SSH key for the user account

Global Options
  -l, --rhlogin login       OpenShift login
  -p, --password password   OpenShift password
  -d, --debug               Turn on debugging
  --noprompt                Do not ask for input
  --config FILE             Path of a different config file
  -h, --help                Display help documentation
  -v, --version             Display version information
  -t, --trace               Display backtrace when an error occurs


Expected results:
'update' action show be removed from man page and help infos. 
Now that CLI already has this command deprecated, man page and help should also be consistent with CLI.

Additional info:

Comment 1 Jianwei Hou 2012-09-05 03:15:35 UTC

Also have deprecated help information in rhc sshkey add/update/remove

Steps to reproduce:
1. rhc rhc sshkey add --help

[root@ip-10-111-7-229 .ssh]# rhc sshkey add --help
Usage: rhc sshkey add <name> <SSH Key file>

Add SSH key to the user account

Options for sshkey add
  --timeout timeout         Timeout, in seconds, for the session
  -i, --identifier name     Name for this key
  -k, --ssh key-filepath    SSH public key filepath

Global Options
  -l, --rhlogin login       OpenShift login
  -p, --password password   OpenShift password
  -d, --debug               Turn on debugging
  --noprompt                Do not ask for input
  --config FILE             Path of a different config file
  -h, --help                Display help documentation
  -v, --version             Display version information
  -t, --trace               Display backtrace when an error occurs
2. Add an sshkey 
   rhc sshkey add -i default -k ~/.ssh/id_rsa.pub

Result:

[root@ip-10-111-7-229 .ssh]# rhc sshkey add -i default -k ~/.ssh/id_rsa.pub 
Missing required argument 'name'.

Additional info:
As we can see with --help, the Usage and Options are inconsistent for 'rhc sshkey add/update/remove'
Now we should use 'rhc sshkey add default ~/.ssh/id_rsa.pub' to add sshkey, the -i, -k flags are deprecated and should not appear in man page and help

Comment 2 jizhao 2012-09-06 11:40:38 UTC

This bug is verified on fork_ami_US2600_76.

Steps to verify:
1. rhc sshkey --help
2. man rhc-sshkey
3. rhc sshkey update --help
4. rhc sshkey update

Results:
1.update             Deprecated. "remove" and "addd" instead.
2.update Deprecated. ’remove’ and ’add’ instead.
3.Deprecated. "remove" and "addd" instead.
4.Update command is deprecated. Please delete and re-add the key with the same name.