Bug 854553

Summary: Review Request: gr-air-modes - SDR receiver for Mode S transponder signals (ADS-B)
Product: [Fedora] Fedora Reporter: Jaroslav Škarvada <jskarvad>
Component: Package ReviewAssignee: Jan Synacek <jsynacek>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jsynacek, notting, package-review
Target Milestone: ---Flags: jsynacek: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-20 15:29:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jaroslav Škarvada 2012-09-05 10:27:52 UTC
Spec URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes.spec
SRPM URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes-0-0.1.20120905git6c7a7370.fc17.src.rpm
Description: Software defined radio receiver for Mode S transponder signals, including ADS-B reports.
Fedora Account System Username: jskarvad

gr-air-modes-add-soname.patch is there to silent rpmlint, patch sent upstream.

Comment 1 Jan Synacek 2012-09-06 14:21:15 UTC
One minor glitch. The Requires(post) and Requires(postun) sections hard-code /sbin/ldconfig. Please use %{_sbindir} instead.

I have not found any other problems with the package.

Comment 2 Jaroslav Škarvada 2012-09-19 09:01:22 UTC
(In reply to comment #1)

Thanks for the review.

> One minor glitch. The Requires(post) and Requires(postun) sections hard-code
> /sbin/ldconfig. Please use %{_sbindir} instead.
> 
I followed the guidelines that use example without macros:
http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

But probably no problem to change.

New versions:
Spec URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes.spec
SRPM URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes-0-0.2.20120905git6c7a7370.fc17.src.rpm

Comment 3 Jan Synacek 2012-09-24 11:48:57 UTC
I also noticed that there is a 'docs' folder in the upstream source containing doxygen documentation. Maybe it would be a good idea to package it as well? E.g. as a '-doc' package?

Comment 4 Jaroslav Škarvada 2012-09-24 12:31:40 UTC
(In reply to comment #3)
> I also noticed that there is a 'docs' folder in the upstream source
> containing doxygen documentation. Maybe it would be a good idea to package
> it as well? E.g. as a '-doc' package?

Thanks for the catch, new files:
Spec URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes.spec
SRPM URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes-0-0.3.20120905git6c7a7370.fc17.src.rpm

Comment 5 Jan Synacek 2012-09-24 13:20:13 UTC
Looks ok now, approving.

Comment 6 Jaroslav Škarvada 2012-09-24 13:22:54 UTC
New Package SCM Request
=======================
Package Name: gr-air-modes
Short Description: SDR receiver for Mode S transponder signals (ADS-B)
Owners: jskarvad
Branches: f17 f18
InitialCC:

Comment 7 Gwyn Ciesla 2012-09-24 13:35:01 UTC
Git done (by process-git-requests).

Comment 8 Jaroslav Škarvada 2012-09-24 20:15:25 UTC
Thanks.

Comment 9 Fedora Update System 2012-09-24 20:47:20 UTC
gr-air-modes-0-0.3.20120905git6c7a7370.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gr-air-modes-0-0.3.20120905git6c7a7370.fc18

Comment 10 Fedora Update System 2012-09-24 20:49:47 UTC
gr-air-modes-0-0.3.20120905git6c7a7370.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gr-air-modes-0-0.3.20120905git6c7a7370.fc17

Comment 11 Fedora Update System 2012-09-25 04:32:03 UTC
gr-air-modes-0-0.3.20120905git6c7a7370.fc17 has been pushed to the Fedora 17 testing repository.

Comment 12 Fedora Update System 2012-09-26 10:05:10 UTC
gr-air-modes-0-0.4.20120905git6c7a7370.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/gr-air-modes-0-0.4.20120905git6c7a7370.fc18

Comment 13 Fedora Update System 2012-09-26 10:05:48 UTC
gr-air-modes-0-0.4.20120905git6c7a7370.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/gr-air-modes-0-0.4.20120905git6c7a7370.fc17

Comment 14 Fedora Update System 2012-12-20 15:29:03 UTC
gr-air-modes-0-0.4.20120905git6c7a7370.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.