Bug 854553
Summary: | Review Request: gr-air-modes - SDR receiver for Mode S transponder signals (ADS-B) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
Component: | Package Review | Assignee: | Jan Synacek <jsynacek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | jsynacek, notting, package-review |
Target Milestone: | --- | Flags: | jsynacek:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-12-20 15:29:01 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Jaroslav Škarvada
2012-09-05 10:27:52 UTC
One minor glitch. The Requires(post) and Requires(postun) sections hard-code /sbin/ldconfig. Please use %{_sbindir} instead. I have not found any other problems with the package. (In reply to comment #1) Thanks for the review. > One minor glitch. The Requires(post) and Requires(postun) sections hard-code > /sbin/ldconfig. Please use %{_sbindir} instead. > I followed the guidelines that use example without macros: http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries But probably no problem to change. New versions: Spec URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes.spec SRPM URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes-0-0.2.20120905git6c7a7370.fc17.src.rpm I also noticed that there is a 'docs' folder in the upstream source containing doxygen documentation. Maybe it would be a good idea to package it as well? E.g. as a '-doc' package? (In reply to comment #3) > I also noticed that there is a 'docs' folder in the upstream source > containing doxygen documentation. Maybe it would be a good idea to package > it as well? E.g. as a '-doc' package? Thanks for the catch, new files: Spec URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes.spec SRPM URL: http://fedorapeople.org/~jskarvad/gr-air-modes/gr-air-modes-0-0.3.20120905git6c7a7370.fc17.src.rpm Looks ok now, approving. New Package SCM Request ======================= Package Name: gr-air-modes Short Description: SDR receiver for Mode S transponder signals (ADS-B) Owners: jskarvad Branches: f17 f18 InitialCC: Git done (by process-git-requests). Thanks. gr-air-modes-0-0.3.20120905git6c7a7370.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gr-air-modes-0-0.3.20120905git6c7a7370.fc18 gr-air-modes-0-0.3.20120905git6c7a7370.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gr-air-modes-0-0.3.20120905git6c7a7370.fc17 gr-air-modes-0-0.3.20120905git6c7a7370.fc17 has been pushed to the Fedora 17 testing repository. gr-air-modes-0-0.4.20120905git6c7a7370.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/gr-air-modes-0-0.4.20120905git6c7a7370.fc18 gr-air-modes-0-0.4.20120905git6c7a7370.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gr-air-modes-0-0.4.20120905git6c7a7370.fc17 gr-air-modes-0-0.4.20120905git6c7a7370.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |