Bug 854605
| Summary: | Review Request: python-moksha-common - Common components for Moksha | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Patrick Uiterwijk <puiterwijk> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, puiterwijk |
| Target Milestone: | --- | Flags: | puiterwijk:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-06 00:24:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 854608, 854609 | ||
|
Description
Ralph Bean
2012-09-05 12:25:30 UTC
Quick second release: disable tests since they are failing in koji. It's something odd with the version of python-mock. Spec URL: http://threebean.org/rpm/python-moksha-common.spec SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-2.fc17.src.rpm I'll review this soon. Quick third release changing license to the more correct "ASL 2.0 or MIT": Spec URL: http://threebean.org/rpm/python-moksha-common.spec SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-3.fc17.src.rpm Still another: Use %{optflags}:
Spec URL: http://threebean.org/rpm/python-moksha-common.spec
SRPM URL: http://threebean.org/rpm/python-moksha-common-1.0.0-4.fc17.src.rpm
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistent macro usage. OK - Meets Packaging Guidelines. OK - License (ASL 2.0 or MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum. OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. See below - Package has a correct %clean section. See below - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. This spec is not allowed for el5 as it misses the buildroot and %clean sections. 2. rpmlint says: python-moksha-common.noarch: W: no-manual-page-for-binary moksha 2 packages and 1 specfiles checked; 0 errors, 1 warnings. I see no blockers anymore, so this package is APPROVED. New Package SCM Request ======================= Package Name: python-moksha-common Short Description: Common components for Moksha Owners: ralph lmacken Branches: f16 f17 f18 el6 InitialCC: Git done (by process-git-requests). Bodhi updates -> https://admin.fedoraproject.org/updates/python-moksha-common |