Bug 854609

Summary: Review Request: python-moksha-hub - Hub components for Moksha
Product: [Fedora] Fedora Reporter: Ralph Bean <rbean>
Component: Package ReviewAssignee: Patrick Uiterwijk <puiterwijk>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, puiterwijk
Target Milestone: ---Flags: puiterwijk: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-10 13:42:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 854605    
Bug Blocks:    

Description Ralph Bean 2012-09-05 12:28:52 UTC
Spec URL: http://threebean.org/rpm/python-moksha-hub.spec
SRPM URL: http://threebean.org/rpm/python-moksha-hub-1.0.0-1.fc17.src.rpm
Description: Hub components for Moksha
Fedora Account System Username: ralph

rpmlint output:
python-moksha-hub.noarch: W: no-manual-page-for-binary moksha-hub
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

koji - f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4456766

There already exists a package moksha (version 0.8.8 in rawhide).  I've done work upstream to split it into three different namespace packages to lighten the dependency load on some machines.

Comment 1 Patrick Uiterwijk 2012-09-05 13:12:43 UTC
I'll review this soon.

Comment 2 Ralph Bean 2012-09-05 14:43:08 UTC
New release:  use %{optflags}

Spec URL: http://threebean.org/rpm/python-moksha-hub.spec
SRPM URL: http://threebean.org/rpm/python-moksha-hub-1.0.0-3.fc17.src.rpm

Comment 3 Ralph Bean 2012-09-06 13:19:07 UTC
FYI, a buildroot override for python-moksha-common has been created which makes this now buildable in koji.  For example:

koji - f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4460498

Comment 4 Patrick Uiterwijk 2012-09-07 21:48:31 UTC
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistent macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (ASL 2.0)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum.

OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good. 
See below - Package has a correct %clean section. 
See below - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output. 
OK - final provides and requires are sane.

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should function as described. 
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin

Issues: 
1. This spec is not allowed for el5 as it misses the buildroot and %clean sections. 

2. rpmlint says: 
python-moksha-hub.noarch: W: no-manual-page-for-binary moksha-hub
2 packages and 0 specfiles checked; 0 errors, 1 warnings.


I see no blockers anymore, so this package is APPROVED.

Comment 5 Ralph Bean 2012-09-07 22:40:12 UTC
New Package SCM Request
=======================
Package Name: python-moksha-hub
Short Description: Hub components for Moksha
Owners: ralph lmacken
Branches: f16 f17 f18 el6
InitialCC:

Comment 6 Gwyn Ciesla 2012-09-08 14:35:16 UTC
Git done (by process-git-requests).

Comment 7 Ralph Bean 2012-09-10 13:42:50 UTC
Updates -> https://admin.fedoraproject.org/updates/python-moksha-hub