Bug 854679
| Summary: | Review Request: python-sudsds - A python SOAP client modified for usage with Czech Databox | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Jan Synacek <jsynacek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jsynacek, notting, package-review |
| Target Milestone: | --- | Flags: | jsynacek:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-20 15:34:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 854690 | ||
|
Description
Jaroslav Škarvada
2012-09-05 14:35:50 UTC
*** Bug 854681 has been marked as a duplicate of this bug. *** Specfile:
- use %global instead of %define
- do not use BuildRoot:
- do not use rm -rf %{buildroot} in install section (unless you intend to use the package for EPEL)
- do not use %defattr (unless you intend to use the package for EPEL)
- also, I believe there is a typo on line 36:
+ rm -f {buildroot}... should probably be rm -f %{buildroot}...
Also, rpmlint complains a lot about incorrect fsf addresses:
python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/transport/https.py
python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/bindings/__init__.py
python-sudsds.noarch: E: incorrect-fsf-address /usr/lib/python2.7/site-packages/sudsds/mx/typer.py
That should probably be reported and corrected by upstream.
Other than that, I don't see any more things that need correction. The package also does not conflict with 'python-suds' that is already present in Fedora.
A few more things after all.
According to python packaging guidelines, you don't have to define python_sitelib macro on the first line in the spec.
"In RHEL 5 and older, python2 packages that install python modules need to define python_sitelib or python_sitearch macros that tell where to find the python directory that modules are installed in. This is not needed in current Fedora or with python3 modules as the macros are defined by rpm and the python3-devel package."
Also, instead of calling 'python' directly, use the %{__python} macro.
Thanks for the review. > Specfile: > - use %global instead of %define > > According to python packaging guidelines, you don't have to define > python_sitelib macro on the first line in the spec. > > - do not use BuildRoot: > > - do not use rm -rf %{buildroot} in install section (unless you intend to > use the package for EPEL) > > - do not use %defattr (unless you intend to use the package for EPEL) > I think I needn't, but I can. Personally I am keeping compatibility with old EPELs everywhere, but currently python-dslib is not compatible thus I also removed it from this package. > - also, I believe there is a typo on line 36: > + rm -f {buildroot}... should probably be rm -f %{buildroot}... > Thanks for the catch, fixed. > Also, rpmlint complains a lot about incorrect fsf addresses: > python-sudsds.noarch: E: incorrect-fsf-address > /usr/lib/python2.7/site-packages/sudsds/transport/https.py > python-sudsds.noarch: E: incorrect-fsf-address > /usr/lib/python2.7/site-packages/sudsds/bindings/__init__.py > python-sudsds.noarch: E: incorrect-fsf-address > /usr/lib/python2.7/site-packages/sudsds/mx/typer.py > > That should probably be reported and corrected by upstream. > I am going to report this. > Also, instead of calling 'python' directly, use the %{__python} macro. Fixed. New versions: Spec URL: http://fedorapeople.org/~jskarvad/datovka/python-sudsds.spec SRPM URL: http://fedorapeople.org/~jskarvad/datovka/python-sudsds-1.0-2.fc17.src.rpm No other problems that I can see. Approving. New Package SCM Request ======================= Package Name: python-sudsds Short Description: A python SOAP client modified for usage with Czech Databox Owners: jskarvad Branches: f17 f18 InitialCC: Git done (by process-git-requests). datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/datovka-2.1.2-2.fc18,python-dslib-2.1.2-2.fc18,python-sudsds-1.0-2.fc18 python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-sudsds-1.0-2.fc17,python-dslib-2.1.2-2.fc17,datovka-2.1.2-2.fc17 python-sudsds-1.0-2.fc17, python-dslib-2.1.2-2.fc17, datovka-2.1.2-2.fc17 has been pushed to the Fedora 17 testing repository. datovka-2.1.2-2.fc18, python-dslib-2.1.2-2.fc18, python-sudsds-1.0-2.fc18 has been pushed to the Fedora 18 stable repository. |