Bug 854777

>02:34:14,684 WARNING kernel:Modules linked in: be2iscsi(+)(U) bnx2 ipv6 

You've loaded an unsigned kernel module and that's where the errors are coming from.

We do not support this module.

P.

Prarit,
This has nothing to do with the module, it's still a kernel bug which needs to be fixed.  Any module that calls pci_free_consistent will hit the problem during rhel6.3 i386 installation.

-Minh

(In reply to comment #3)
> Prarit,
> This has nothing to do with the module, it's still a kernel bug which needs
> to be fixed.  Any module that calls pci_free_consistent will hit the problem
> during rhel6.3 i386 installation.
> 

Hmm ... okay, I'll take a look but I'm pretty sure we have 32-bit drivers that call pci_free_consistent() and don't exhibit a problem.

P.

(In reply to comment #3)
> Prarit,
> This has nothing to do with the module, it's still a kernel bug which needs
> to be fixed.  Any module that calls pci_free_consistent will hit the problem
> during rhel6.3 i386 installation.
> 
> -Minh

Sorry, I don't see this behaviour.  I created a simple module that allocated (via pci_alloc_consistent) a 8 byte chunk of memory to the root bridge on module load.  I then free'd the memory (via pci_free_consistent) the 8 byte chunk of memory and don't see any problems.

This is a bug in the upstream be2iscsi driver.

P.

(In reply to comment #5)
> (In reply to comment #3)
> > Prarit,
> > This has nothing to do with the module, it's still a kernel bug which needs
> > to be fixed.  Any module that calls pci_free_consistent will hit the problem
> > during rhel6.3 i386 installation.
> > 
> > -Minh
> 
> Sorry, I don't see this behaviour.  I created a simple module that allocated
> (via pci_alloc_consistent) a 8 byte chunk of memory to the root bridge on
> module load.  I then free'd the memory (via pci_free_consistent) the 8 byte
> chunk of memory and don't see any problems.
> 

Oh sorry -- I forgot the spin_lock_irq() part.

Yeah ... That still isn't a bug.  The problem is that you shouldn't be disabling interrupts during a free consistent.  The kernel cannot handle that.  ... ie) this is still a bug in the be2iscsi driver.

P.

Prarit,
Sorry about the confusion, I've not clearly tell you how to reproduce it.  The problem is that interrupts is already disabled when it calls the be2iscsi driver module probe.  My educated guess is interrupt has been disabled via spin_lock_irqsave() but it's also possible disable_irq() has been called.  To prove it's a kernel issue, here is how you do it:

1) compile a driver in rhel6.2 i386 with WARN_ON(irqs_disabled()) added immediately at the driver pci_dev_probe entry point.
2) make a DUD.iso to load during installation.
3) boot with rhel6.3 i386 OS installation CD then add driver in DUD.iso
4) after driver loads, look at /tmp/syslog or dmesg to see kernel trace

Note: this situation only happens with the rhel6.3 i386 installation CD, during __driver_attach context.

(In reply to comment #8)
> Prarit,
> Sorry about the confusion, I've not clearly tell you how to reproduce it. 
> The problem is that interrupts is already disabled when it calls the
> be2iscsi driver module probe.  My educated guess is interrupt has been
> disabled via spin_lock_irqsave() but it's also possible disable_irq() has
> been called.  To prove it's a kernel issue, here is how you do it:
> 
> 1) compile a driver in rhel6.2 i386 with WARN_ON(irqs_disabled()) added
> immediately at the driver pci_dev_probe entry point.
> 2) make a DUD.iso to load during installation.
> 3) boot with rhel6.3 i386 OS installation CD then add driver in DUD.iso
> 4) after driver loads, look at /tmp/syslog or dmesg to see kernel trace
> 
> Note: this situation only happens with the rhel6.3 i386 installation CD,
> during __driver_attach context.

I did the following on a system which required the be2net driver.

1.  Modified the source with

diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 6da26f4..0800f5d 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -3534,6 +3534,32 @@ static int __devinit be_probe(struct pci_dev *pdev,
        struct be_adapter *adapter;
        struct net_device *netdev;
 
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       printk(KERN_EMERG "LOADING MODIFIED BE2NET DRIVER\n");
+       WARN_ON(in_interrupt());
+
        status = pci_enable_device(pdev);
        if (status)
                goto do_none;


2.  built dud disk, burned to CD.

3.  started install with "dd" option

4.  Inserted driver disk when prompted to

5.  Hit ALT-F4 to watch kernel messages.

6.  I see "LOADING MODIFIED BE2NET DRIVER" (like I expect to from the above printks), but do not see a stack trace from the WARN_ON()



This is likely a bug in your proprietary driver.

P.