Bug 854849

updating spec file name
Spec URL: http://people.fedoraproject.org/~tdabasin/taskjuggler/rubygem-taskjuggler.spec
SRPM URL: http://people.fedoraproject.org/~tdabasin/taskjuggler/rubygem-taskjuggler-3.3.0-1.src.rpm

Created attachment 915505 [details]
Comment

(This comment was longer than 65,535 characters and has been moved to an attachment by Red Hat Bugzilla).

Hi, many thanks for taking up the review and feedback.
Spec URL: http://people.fedoraproject.org/~tdabasin/taskjuggler/rubygem-taskjuggler.spec
SRPM URL: http://people.fedoraproject.org/~tdabasin/taskjuggler/rubygem-taskjuggler-3.3.0-2.fc19.src.rpm

I have updated the spec, please see diff [1], scratch build[2]. With regards to rpmlint errors I have noticed that upstream uses header.tmpl file in /usr/share/gems/gems/taskjuggler-3.3.0/lib/header.tmpl which is a template of all ruby files. I'll speak to the maintainer asking to chmod ruby files to +x, but rpmlint will still throw an error because header.tmpl file itself contains:
#!/usr/bin/env ruby -w so I'm not sure how to proceed there, any advice appreciated.

Again, thanks very much for your time.


[1] http://tdabasin.fedorapeople.org/taskjuggler/package_review_feedback_action.html
[2] http://koji.fedoraproject.org/koji/taskinfo?taskID=4593096

I haven't check how are those files used, but usual way to fix this kind of errors is to remove the first line from scripts that are not executed.

Each script source file should match one of the following scenario:
1) Executable - has shebang line (starting with #!) and executable bit (chmod +x)
2) Non-executable - no shebang line and no executable bit

But I'm OK with letting it be as it is. This error is far from being anyhow serious.


Since you've fixed all the issues, I'm setting fedora-review+.

Hi,
I wasn't sure if I should apply patch to replace #! in rb files (#! might be there for a reason), I'll speak with upstream and try to get this fixed/clarified there.

Many thanks Radek

New Package SCM Request
=======================
Package Name: rubygem-taskjuggler
Short Description: A Project Management Software
Owners: tdabasin
Branches: f17 f18 f19

Git done (by process-git-requests).

Radek, please take ownership of review BZs, thanks!

Sorry, forgot that. Thanks.

rubygem-taskjuggler-3.3.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-taskjuggler-3.3.0-2.fc18

rubygem-taskjuggler-3.3.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/rubygem-taskjuggler-3.3.0-2.fc17

rubygem-taskjuggler-3.3.0-2.fc18 has been pushed to the Fedora 18 testing repository.

The package doesn't comply with the Ruby packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Ruby

* %prep and %build are empty which is the old standard and is no longer correct
  https://fedoraproject.org/wiki/Packaging:Ruby#Building_gems
* Documentation for the gem is quite large and should be split off into a doc subpackage
* Not all test frameworks in the Rakefile are run in %check
* A bug in the tests that are run allow them to fail and still return 0
  Each test returns results such as "cannot load such file -- taskjuggler/deep_copy" and "cannot load such file -- term/ansicolor"

Created attachment 633053 [details]
build log with failing test cases

I had already started packaging rubygem-taskjuggler for my own use and ran into the attached problem with test suite. This also addresses some of the issues outlined in my previous comment.

Spec URL: http://rharrison.fedorapeople.org/package_review/rubygem-taskjuggler-3.3.0-3.fc19.spec
SRPM URL: http://rharrison.fedorapeople.org/package_review/rubygem-taskjuggler-3.3.0-3.fc19.src.rpm

Russell, 
thanks for your feedback, I have looked at the packaging guidelines and your spec. I'm basing my spec on yours[1]. With regards to the tests, I have noticed that tests pass if called via shell:

$ testrb -Ilib /home/makerpm/rpmbuild/BUILDROOT/rubygem-taskjuggler-3.3.0-2.el6.x86_64/usr/share/gems/gems/taskjuggler-3.3.0/test
Run options: -Ilib

# Running tests:

............................................................................................................

Finished tests in 88.454893s, 1.2210 tests/s, 2962.4704 assertions/s.

108 tests, 262045 assertions, 0 failures, 0 errors, 0 skips

I have removed 2 tests that fail on rpmbuild from the spec. I have also changed rspec test definition. Please have a look at the package[2] and let me know what you think.

[1] http://pkgs.fedoraproject.org/cgit/rubygem-taskjuggler.git/commit/?id=8b84daef0eab8ac78057c30941698349dfdda733
[2] http://kojipkgs.fedoraproject.org//work/tasks/4418/4624418/rubygem-taskjuggler-3.3.0-3.fc19.src.rpm

(In reply to comment #14)
You sir, are fast indeed.

I think things are looking good for pushing to the repos now.

To clean up the failing test we could ping the ruby-sig list to see if anyone has any incite into why they fail. I suspect its something simple like a missing BuildRequire, but at least with the newer guidelines we can patch the tests if we need to.

Good work!

rubygem-taskjuggler-3.3.0-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-taskjuggler-3.3.0-3.fc18

rubygem-taskjuggler-3.3.0-2.fc18 has been pushed to the Fedora 18 stable repository.