Bug 855250
Summary: | Change the default filtering for Quick and Cangjie | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ding-Yi Chen <dchen> |
Component: | ibus-table-chinese | Assignee: | Ding-Yi Chen <dchen> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | medium | ||
Version: | 18 | CC: | apatel, awilliam, bochecha, damage3025, dchen, i18n-bugs, jni, K9, kent.neo, mfabian, petersen, shawn.p.huang |
Target Milestone: | --- | Keywords: | Reopened |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AcceptedNTH | ||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 834971 | Environment: | |
Last Closed: | 2013-01-10 03:09:04 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 752665 |
Description
Ding-Yi Chen
2012-09-07 06:10:00 UTC
This exact bug was also reported upstream: https://code.google.com/p/ibus/issues/detail?id=1188 I worked on it with maxiaojun and this bug is now fixed in his personal fork of ibus-table-chinese: https://github.com/maxiaojun/ibus-table-chinese/commit/8ab171e815471bcace3aa27e506e7921364901c3 Note that it depends on the related changes he made to ibus-table. The only thing needed is for someone in upstream IBus to review his changes, merge them with the canonical upstream repos for ibus-table and ibus-table-chinese, and include the changes in the next releases. Caius Chance told me that you (Ding Yi Chen) had taken over from him when he left Red Hat. If that's still the case, could you review maxiaojun's changes and eventually merge them? ibus-table-chinese-1.4.0-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.0-1.fc18 ibus-table-chinese-1.4.0-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.0-1.fc17 ibus-table-chinese-1.4.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.0-1.fc16 ibus-table-chinese-1.4.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.0-1.el6 (In reply to comment #1) Mathieu> Mathieu> Note that it depends on the related changes he made to ibus-table. Mathieu> Here are builds of Caius Chance’s latest git, i.e. from this commit: https://github.com/kaio/ibus-table/commit/e90dc055de4e5ecda91ae03144be9731c8376989 http://koji.fedoraproject.org/koji/taskinfo?taskID=4466018 (ibus-table-1.4.99.20120907-1.fc18.src.rpm, x86_64) http://koji.fedoraproject.org/koji/taskinfo?taskID=4466056 (ibus-table-1.4.99.20120907-1.fc18.src.rpm, i686) They include the fix for https://code.google.com/p/ibus/issues/detail?id=1188 Package ibus-table-chinese-1.4.0-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ibus-table-chinese-1.4.0-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-13541/ibus-table-chinese-1.4.0-1.fc18 then log in and leave karma (feedback). (In reply to comment #6) > (In reply to comment #1) > Mathieu> > Mathieu> Note that it depends on the related changes he made to ibus-table. > Mathieu> > > Here are builds of Caius Chance’s latest git, i.e. from this commit: > > https://github.com/kaio/ibus-table/commit/ > e90dc055de4e5ecda91ae03144be9731c8376989 > > http://koji.fedoraproject.org/koji/taskinfo?taskID=4466018 > (ibus-table-1.4.99.20120907-1.fc18.src.rpm, x86_64) > > http://koji.fedoraproject.org/koji/taskinfo?taskID=4466056 > (ibus-table-1.4.99.20120907-1.fc18.src.rpm, i686) > > They include the fix for https://code.google.com/p/ibus/issues/detail?id=1188 Mike, if I understand correctly what Chen wanted to do, this bug is only about ibus-table-chinese, so you should probably write that as a comment of bug 834971. In any case, I tested your build, along with Chen's update, and together they fix this bug and bug 834971 for me. :) Thanks a lot to both of you! Well, I don't think the previous ibus-table support the required feature. Thus, Caius has made the change on ibus-table side. ibus-table-chinese-1.4.0-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. ibus-table-chinese-1.4.0-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. ibus-table-chinese-1.4.0-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. ibus-table-chinese-1.4.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. Recently uploaded ibus-table-chinese-1.4.0 doesn't fix the problem. My test environment is GNOME 3.6 live image. Reproducing procedure: sqlite3 /usr/share/ibus-table/tables/${name}.db (In the SQLite shell) SELECT * FROM ime; Can you see 'select_keys' or 'language_filter'? I can't. And the notorious Chinese mode / page size bugs still exist. The tricky thing here is that you have to use recent (newer than 20120907) version of ibus-table to build the SQLite databases for ibus-table-chinese-1.4.0. Otherwise, 'select_keys' and 'language_filter' property would be silently ignored by older version of ibus-table. Without such crucial meta-data, newly added logic to fix the notorious bug in newer version of ibus-table becomes a NOP. So, please rebuild ibus-table-chinese-1.4.0 and build it correctly. ibus-table-chinese-1.4.5-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.5-1.fc18 ibus-table-chinese-1.4.5-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.5-1.fc17 ibus-table-chinese-1.4.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.5-1.fc16 ibus-table-chinese-1.4.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.5-1.el6 ibus-table-chinese-1.4.6-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.6-1.fc18 ibus-table-chinese-1.4.6-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.6-1.fc17 ibus-table-chinese-1.4.6-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.6-1.fc16 ibus-table-chinese-1.4.6-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ibus-table-chinese-1.4.6-1.el6 ibus-table-chinese-1.4.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. ibus-table-chinese-1.4.6-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. ibus-table-chinese-1.4.6-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. So we have an update for this bug which is pending stable for F18: https://admin.fedoraproject.org/updates/FEDORA-2012-19644 I'm thus noiminating this bug as a NTH for F18 Final, because: 1. without this update, Hong Kong users will not be able to input Traditional Chinese out of the box (they will have to update first) 2. the package only contains data, and nothing requires it 3. the update was already pushed to stable in F16 and F17, so the upgrade path is broken at the moment I realize it is very late in the schedule to nominate a new NTH bug, but I had just assumed this had reached stable a while ago. Sorry about that. If it's too late, well, too bad, it will be available as an update anyway. :) re-opening for F18. Discussed at 2012-01-03 go/no-go meeting: http://meetbot.fedoraproject.org/fedora-meeting-1/2013-01-03/f18_final_gono-go_meeting.2013-01-03-17.01.log.txt . Accepted as NTH as a clear improvement to default input configuration for Hong Kong users, cannot be entirely fixed with an update. ibus-table-chinese-1.4.6-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |