Bug 855716

Summary: beaker-transfer stuck in while loop, when disabling cache with untransferred logs
Product: [Community] Beaker Reporter: Raymond Mancy <rmancy>
Component: lab controllerAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: Amit Saha <asaha>
Severity: unspecified Docs Contact:
Priority: low    
Version: 0.9CC: asaha, bpeck, dcallagh, ebaak, kbaker, llim, qwan, rmancy
Target Milestone: 0.12   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Misc
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-04-11 04:56:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Raymond Mancy 2012-09-10 05:48:06 UTC
If you set:

  CACHE = False

in labcontroller.conf when there are untransferred logs, then beaker-transfer gets stuck in a while loop.

This is because it returns True for transfer.transfer_logs() so does not enter sleep, and then transfer_recipe_logs() returns straightaway as CACHE is not enabled.

Comment 1 Dan Callaghan 2012-09-10 06:58:23 UTC
Maybe beaker-transfer should just bail out entirely if CACHE=False? It has no purpose otherwise.

Ideally it should exit non-zero before daemonising, then the administrator will see a big fat red "FAILED" if they try to start it when CACHE=False.

Comment 2 Nick Coghlan 2012-10-17 04:33:36 UTC
Bulk reassignment of issues as Bill has moved to another team.

Comment 3 Dan Callaghan 2013-02-25 05:50:00 UTC
I wrote a patch for this while working on the harness API:

http://gerrit.beaker-project.org/1702

Comment 5 Amit Saha 2013-04-05 01:28:42 UTC
Due to the changes in log storage mechanism, the CACHE variable is defunct now. (See: http://beaker-project.org/docs-release-0.12/whats-new/release-0.12.html#logs-are-no-longer-sent-to-the-beaker-server)

The above patch adds the intelligence to beaker-transfer to bail out if ARCHIVE_SERVER is not configured. This is verified to be working as expected:

# service beaker-transfer start

Starting beaker-transfer: Archive server settings are missing from config file
                                                           [FAILED]

Comment 6 Dan Callaghan 2013-04-11 04:56:01 UTC
Beaker 0.12 has been released.