Bug 855990

Summary:	stickshift-proxy is failed after reload on Fedora 17 and later
Product:	OKD	Reporter:	Rob Millner <rmillner>
Component:	Containers	Assignee:	Rob Millner <rmillner>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.x	CC:	mfisher
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-09-17 21:28:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Rob Millner 2012-09-10 21:12:36 UTC

Description of problem:
After updating the proxy configuration, a service reload on stickshift-proxy causes the service to show as failed and systemd to terminate the haproxy daemon.

The underlying issue is that systemd is confused by the daemon changing PIDs on reload.

Version-Release number of selected component (if applicable):
Fedora 17 and later.

How reproducible:
Always on affected Fedoras

Steps to Reproduce:
1. systemctl status stickshift-proxy.service
2. systemctl reload stickshift-proxy.service
3. systemctl status stickshift-proxy.service
  
Actual results:
Service shows up as failed and is terminated

Expected results:
Service properly reloads and is not terminated.

Additional info:

Comment 1 Rob Millner 2012-09-10 21:16:56 UTC

See Bug 721375 ; A similar issue was discovered with sshd and the resolution was to treat sshd as a "simple" service that does not fork into the background.

Comment 2 Rob Millner 2012-09-10 21:19:16 UTC

The PID file is no longer updated when haproxy is not run in daemon mode.  Our procedures assuming it should change appropriately.

Comment 3 Rob Millner 2012-09-11 20:57:58 UTC

The following pull request creates a wrapper script for LSB compliance.

https://github.com/openshift/crankcase/pull/474

Comment 4 Rob Millner 2012-09-12 17:17:14 UTC

Pull request accepted.