Bug 856764
|
Description
Neil Horman
2012-09-12 18:39:50 UTC
Created attachment 689769 [details] Add missing EEE definitions and functions Hello, The attached patch adds missing EEE definitions and functions. Currently they are required by Intel's out-of-tree driver in order to compile, but they might also be used by future driver backports which implement EEE. For Intel's case see https://bugzilla.redhat.com/show_bug.cgi?id=896263 The patch is a straightforward backport of the following 3 commits (in order): 1. c44f7eb4c127be8bb8b160902845b88d489492e5 'mii: Convert spaces to tabs in mii.h' 2. a59a4d1921664da63d801ba477950114c71c88c9 'phy: add the EEE support and the way to access to the MMD registers.' 3. b32607dd47d456b99f0a16f1c37bc8a0975ffb19 'mdio: translation of MMD EEE registers to/from ethtool settings' Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=5327818 The patch is against kernel-2.6.32-356. I have chosen to backport the first patch as it makes the others apply cleanly and brings the state closer to upstream. In case this is not accepted I can only post the definitions (which are the required bare minimum for the out-of-tree drivers to compile), but I think it is beneficial to have the full backport. Best regards, Nik Created attachment 694140 [details]
Add eth_zero_addr() support function to support ethernet type drivers
Upcoming new driver family: rtlwifi needs this small change to be sync'ed upstream. It's a small change, very confined, and applicable to most ethernet kindred. f931ce161d2b3772e554491b9206a534442d4a9c etherdevice: introduce help function eth_zero_addr() I have it running in my build now, not issues and it's already upstream. Hey guys, sorry for the delay, I'll push all of these tomorrow. (In reply to comment #4) > Upcoming new driver family: rtlwifi needs this small change to be sync'ed > upstream. It's a small change, very confined, and applicable to most > ethernet kindred. > > f931ce161d2b3772e554491b9206a534442d4a9c etherdevice: introduce help > function eth_zero_addr() > > I have it running in my build now, not issues and it's already upstream. Actually I was going to post this now for #870635 as it's needed there. Not sure what's the best way to proceed here. I could delay the fix till Neil posts the series but that's probably going to take a while. Or we rebase once the fix is in. Thoughts? note: in response to comment 4, commit f931ce61d doesn't exist (I think thats just in your local tree john). The upstream commit is 6d57e9078e880a3dd232d579f42ac437a8f1ef7b The following commits have been pushed to the 65-common-net-backports branch: c44f7eb4c127be8bb8b160902845b88d489492e5 a59a4d1921664da63d801ba477950114c71c88c9 b32607dd47d456b99f0a16f1c37bc8a0975ffb19 6d57e9078e880a3dd232d579f42ac437a8f1ef7b Thanks Neil, will tend to it. Just as an FYI, this bug will be getting posted to RHKL on or about august 1'st, 2013 This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux release for currently deployed products. This request is not yet committed for inclusion in a release. The following commits have been pushed to the 65-common-net-backports branch: fa9ee9c4b9885dfdf8eccac19b8b4fc8a7c53288 Liang, this bug, like the 6.4 and 6.3 backport trackers that preceded it, are tested implicitly. if you test the bugs that this bug blocks, the code modified by this bug will be implicitly exercised. update - I'll be posting this a bit sooner, around 7/10/13. If thats a problem for anyone, please speak up There have been no updates requested in this backport tracker for several weeks now. any objections to my posting it a bit early, to give more runway to driver posts/reviews? I'm about adding patches, just waiting brew build to finish. I think earlier post will be better - patches that will not make it can be posted separately together with particular driver backport. Created attachment 765630 [details]
0001-workqueue-add-work_busy.patch
Created attachment 765631 [details]
0002-net-add-ETH_P_802_3_MIN.patch
Created attachment 765632 [details]
0003-netlink-add-signed-types.patch
Created attachment 765633 [details]
0004-netlink-advertise-incomplete-dumps.patch
Created attachment 765634 [details]
0005-kconfig-Introduce-IS_ENABLED-IS_BUILTIN-and-IS_MODUL.patch
Created attachment 765635 [details]
0006-net-add-netdev_features_t.patch
Created attachment 765636 [details]
0007-etherdevice-introduce-eth_broadcast_addr.patch
Created attachment 765637 [details]
0008-etherdevice.h-Add-is_unicast_ether_addr-function.patch
Created attachment 765639 [details]
0009-net-add-mac_pton.patch
Created attachment 765640 [details]
0010-pci-add-PCI_EXP_LNKCTL_ASPM_-L1-L0S.patch
Created attachment 765641 [details]
0011-Input-add-KEY_WPS_BUTTON-definition.patch
Created attachment 765642 [details]
0012-Driver-core-create-lock-unlock-functions-for-struct-.patch
Created attachment 765643 [details]
0013-netdev-add-netdev_continue_rcu.patch
Above 13 patches are needed for wireless subsystem update for bug 882300. http://brewweb.devel.redhat.com/brew/taskinfo?taskID=5953298 Test build to validate sanity stanislaw, I wish you had these to me a bit sooner. some fixups were needed when applying, but I think its for the most part ok. Please rebase your wireless backport to the head of the 65-common-net-backports branch, and do a test build for me to confirm. Please post the brew build here along with your testing results, and I'll get these posted. thanks Neil, sorry for late posting. Patches were based on -392.el6 (plus 65-common-net-backports branch pulled from your repo), so that the reason they do not apply cleanly on the branch which is -358.el6 based. I prefer to use newer kernel. Could you rebase ? (I believe "git rebase master 65-common-net-backports" should do the trick without problem). Regarding testing, I still need some work to make wireless backport compile. Those patches are just prerequisites, but some internal changes are needed to make backport work. Probably on the next week I would be able to do some first runtime tests. So far I can only tell the patches are compile "tested". Anyway, if you fill that those patches are troubles for you, I'm perfectly fine if you eventually drop them. I can post them as part of wireless update (for bug 882300) if needed to avoid unnecessary problems. Thanks. yeah, ok, if we can't test these soon, then I think the best course of action is for me to revert these changes and have you post without them. They don't look like they're any big deal, but if I can't say I tested them, I'll get grief about it on rhkl Patch(es) available on kernel-2.6.32-401.el6 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-1645.html |