Bug 856893

Summary: livecd-tools 18.9+ cannot compose 32-bit lives because the rejigged EFI support is not at all 32-bit safe
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: livecd-toolsAssignee: Brian Lane <bcl>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 18CC: adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj, satellitgo
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-20 20:34:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Adam Williamson 2012-09-13 05:15:31 UTC 
The recent changes to the EFI support in livecd-tools work fine on x86_64, but they've completely broken 32-bit composes. It looks like they weren't really written with any consideration for the 32-bit case.

I think what we need to do here is just put in code that stops it trying to make 32-bit images EFI compatible at all. I wasn't aware it did so at all until these problems cropped up, but it looks like it always has, right back to the initial EFI support in 2009 - http://git.fedorahosted.org/cgit/livecd/commit/imgcreate/live.py?id=ceb818924b458b273293b17dd54b482b4581b528 . Probably because that support was written for Intel Macs, and there *were* 32-bit EFI Macs. But we no longer claim to support such systems at all, and we don't put EFI stuff on the 32-bit traditional media. We should stop doing it for lives.

The problems we've found so far are:

1. Adding shim to the 'required packages' for x86 live images causes 32-bit composes to fail because there is no shim package in the 32-bit repos. I fixed this in 18.10-2 by just dropping shim and grub2-efi from livecd-tools' 'required packages' - they're in comps, there's no need for them to be in livecd-tools too.

2. Once that's fixed, compose fails at the end with several "Missing EFI file" errors - this relates to __copy_efi_files in live.py . There is no shim.efi file or gcdx64.efi to copy, in a 32-bit compose, so those two fail and the compose died.

For Alpha RC3 we just rolled back livecd-tools and composed the 32-bit lives with 18.8, but we need a proper 'fix' for the future.
Comment 1 Fedora Update System 2012-09-13 21:15:12 UTC 
livecd-tools-18.11-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/livecd-tools-18.11-1.fc18
Comment 2 Fedora Update System 2012-09-16 17:12:02 UTC 
Package livecd-tools-18.11-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing livecd-tools-18.11-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-13967/livecd-tools-18.11-1.fc18
then log in and leave karma (feedback).
Comment 3 Fedora Update System 2012-09-20 20:34:26 UTC 
livecd-tools-18.11-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.