Bug 856988 (CVE-2012-4419, CVE-2012-4922)

Summary: CVE-2012-4419 CVE-2012-4922 tor: assertion failures in tor_timegm() and compare_tor_addr_to_addr_policy()
Product: [Other] Security Response Reporter: Jan Lieskovsky <jlieskov>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: extras-orphan, pfrields, rh-bugzilla
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: tor 0.2.2.39 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-03-03 14:33:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 856989, 856990    
Bug Blocks:    

Description Jan Lieskovsky 2012-09-13 10:00:12 UTC
Two instances of remotely triggerable assertion failures have been corrected in upstream Tor 0.2.2.39 version ([1]):
o Security fixes:
     - Fix an assertion failure in tor_timegm() that could be triggered
       by a badly formatted directory object. Bug found by fuzzing with
       Radamsa. Fixes bug 6811; bugfix on 0.2.0.20-rc.
     - Do not crash when comparing an address with port value 0 to an
       address policy. This bug could have been used to cause a remote
       assertion failure by or against directory authorities, or to
       allow some applications to crash clients. Fixes bug 6690; bugfix
       on 0.2.1.10-alpha.

References:
[1] https://gitweb.torproject.org/tor.git/blob/release-0.2.2:/ReleaseNotes
[2] http://www.openwall.com/lists/oss-security/2012/09/12/5
[3] http://www.openwall.com/lists/oss-security/2012/09/12/19
[4] http://www.openwall.com/lists/oss-security/2012/09/13/2

Upstream patches: 
[5] https://gitweb.torproject.org/tor.git/commitdiff/973c18bf0e84d14d8006a9ae97fde7f7fb97e404
    (tor_timegm case)
[6] https://gitweb.torproject.org/tor.git/commitdiff/62d96284f7e0f81c40d5df7e53dd7b4dfe7e56a5
    (compare address with port 0 to address policy case)

Comment 1 Jan Lieskovsky 2012-09-13 10:01:45 UTC
These issues affect the versions of the tor package, as shipped with Fedora release of 16 and 17. Please schedule an update.

--

These issues affect the version of the tor package, as shipped with Fedora EPEL 5. Please schedule an update.

Comment 2 Jan Lieskovsky 2012-09-13 10:02:47 UTC
Created tor tracking bugs for this issue

Affects: fedora-all [bug 856989]
Affects: epel-5 [bug 856990]

Comment 3 Kurt Seifried 2012-09-15 15:12:40 UTC
Name: CVE-2012-4419
The compare_tor_addr_to_addr_policy function in or/policies.c in Tor
before 0.2.2.39, and 0.2.3.x before 0.2.3.21-rc, allows remote
attackers to cause a denial of service (assertion failure and daemon
exit) via a zero-valued port field that is not properly handled during
policy comparison.

Name: CVE-2012-4922
The tor_timegm function in common/util.c in Tor before 0.2.2.39, and
0.2.3.x before 0.2.3.22-rc, does not properly validate time values,
which allows remote attackers to cause a denial of service (assertion
failure and daemon exit) via a malformed directory object, a different
vulnerability than CVE-2012-4419.

Comment 4 Fedora Update System 2012-09-24 03:21:16 UTC
tor-0.2.2.39-1800.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 5 Fedora Update System 2013-02-03 13:38:34 UTC
tor-0.2.2.39-1700.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.