Bug 857730

Hi,
I take the review ;-)

I would like to know if your patch is reported to upstream ?

To be honest - I'm not sure. I should have mentioned that this is being moved from the CCRMA repo. I will have to ask Fernando, the maintainer there if he has submitted upstream. I will if he hasn't - I have some further questions for upstream in any case, so that's no problem.

ok i will wait your feedback

Rpmlint
-------
Checking: oscpack-1.0.2-2.fc17.x86_64.rpm
          oscpack-1.0.2-2.fc17.src.rpm
          oscpack-debuginfo-1.0.2-2.fc17.x86_64.rpm
          oscpack-devel-1.0.2-2.fc17.x86_64.rpm
oscpack.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
oscpack.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
oscpack.x86_64: W: no-manual-page-for-binary OscDump
oscpack.x86_64: W: no-manual-page-for-binary OscSendTests
oscpack.x86_64: W: no-manual-page-for-binary OscReceiveTest
oscpack.x86_64: W: no-manual-page-for-binary OscUnitTests
oscpack.src: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
oscpack.src: W: spelling-error %description -l en_US eg -> eh, e, g
oscpack.src: W: invalid-url Source0: http://oscpack.googlecode.com/files/oscpack_1_0_2.zip HTTP Error 404: Not Found
oscpack-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 10 warnings.

warning about invalid-url is false positive warning [Ok]

I would like to know if they are a way to get some doc for OscDump OscSendTests OscReceiveTest OscUnitTests ?

I will ask upstream about man pages, but I doubt anything will come from it.

The reason I'm packaging this is because there is another package (supercollider) which is bundling this. Siupercollider have made changes to the source, so it may take some time before this is ready. You can put it on hold for now.

ok for me it seem it is ok.
Waiting to know if upstream know your patch before end this review .
As fedora want to be close to upstream this step is need.

ping

Thanks

OK, I am merging the supercollider changes into htis package. Upstream has reviewed the patches and placed them in queue.

I have retrieved the most recent source in this update:


SRPM: http://bsjones.fedorapeople.org/oscpack-1.0.2-3.1.svn20110904.fc18.src.rpm
SPEC: http://bsjones.fedorapeople.org/oscpack.spec

ping

ping

sorry for time

Rpmlint (installed packages)
----------------------------
# rpmlint oscpack oscpack-devel
oscpack.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
oscpack.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
oscpack.x86_64: W: incoherent-version-in-changelog 1.0.2-2 ['1.0.2-3.1.svn20110904.fc18', '1.0.2-3.1.svn20110904']
oscpack.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liboscpack.so.1.0.2 /lib64/libm.so.6
oscpack.x86_64: W: no-manual-page-for-binary OscDump
oscpack.x86_64: W: no-manual-page-for-binary OscSendTests
oscpack.x86_64: W: no-manual-page-for-binary OscReceiveTest
oscpack.x86_64: W: no-manual-page-for-binary OscUnitTests
oscpack-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 9 warnings.

please fix log and lib dependency

This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '17'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 17's end of life.

Bug Reporter:  Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 17 is end of life. If you 
would still like  to see this bug fixed and are able to reproduce it 
against a later version  of Fedora, you are encouraged  change the 
'version' to a later Fedora version prior to Fedora 17's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

Please do NOT change release target.

SRPM: http://bsjones.fedorapeople.org/reviews/oscpack-1.0.2-3.1.svn20110904.fc19.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/oscpack.spec

Sorry - have been really busy...

You should preserve the timestamp by install -p.

I would like to know if path is reported to upstream somewhere?

patch*

New upstream now incorporates this patch

SRPM SRPM: http://bsjones.fedorapeople.org/reviews/oscpack-1.1.0-1.fc19.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/oscpack.spec

----------------------------------------------------------------------
Rpmlint
-------
Checking: oscpack-1.1.0-1.fc19.x86_64.rpm
          oscpack-devel-1.1.0-1.fc19.x86_64.rpm
oscpack.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
oscpack.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
oscpack.x86_64: W: file-not-utf8 /usr/share/doc/oscpack-1.1.0/CHANGES
oscpack.x86_64: W: no-manual-page-for-binary SimpleSend
oscpack.x86_64: W: no-manual-page-for-binary SimpleReceive
oscpack.x86_64: W: no-manual-page-for-binary OscReceiveTest
oscpack.x86_64: W: no-manual-page-for-binary OscSendTests
oscpack.x86_64: W: no-manual-page-for-binary OscUnitTests
oscpack.x86_64: W: no-manual-page-for-binary OscDump
oscpack-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint oscpack oscpack-devel
oscpack.x86_64: W: spelling-error %description -l en_US namespaces -> name spaces, name-spaces, names paces
oscpack.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g
oscpack.x86_64: W: unused-direct-shlib-dependency /usr/lib64/liboscpack.so.1.1.0 /lib64/libm.so.6
oscpack.x86_64: W: file-not-utf8 /usr/share/doc/oscpack-1.1.0/CHANGES
oscpack.x86_64: W: no-manual-page-for-binary SimpleSend
oscpack.x86_64: W: no-manual-page-for-binary SimpleReceive
oscpack.x86_64: W: no-manual-page-for-binary OscReceiveTest
oscpack.x86_64: W: no-manual-page-for-binary OscSendTests
oscpack.x86_64: W: no-manual-page-for-binary OscUnitTests
oscpack.x86_64: W: no-manual-page-for-binary OscDump
oscpack-devel.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 11 warnings.
----------------------------------------------------------------------


Please fix:

- /usr/share/doc/oscpack-1.1.0/CHANGES bad encoding

- unused-direct-shlib-dependency

OK, done. Thanks

Also note, I have discovered faust-osclib* bundles a copy of this library. I have added the appropriate Provides/Obsoletes.

SRPM: http://bsjones.fedorapeople.org/reviews/oscpack-1.1.0-2.fc19.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/oscpack.spec

dead tool

feel free to open it again if still a needed package