Bug 85775

Summary: checkisomd5 returns positive return code when all is well.
Product: [Retired] Red Hat Public Beta Reporter: James Olin Oden <james.oden>
Component: anacondaAssignee: Michael Fulbright <msf>
Status: CLOSED RAWHIDE QA Contact: Mike McLean <mikem>
Severity: low Docs Contact:
Priority: low    
Version: phoebe   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2003-03-07 19:18:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James Olin Oden 2003-03-07 16:12:54 UTC
Description of problem:
If checkisomd5 says that a ISO image passes, it will return 1.

Version-Release number of selected component (if applicable):
anaconda 8.0.95

How reproducible:
Always

Steps to Reproduce:
1.  Create an iso image.
2.  Run implantisomd5 against it.
3.  Run checkisomd5 against it.
4.  Check the return code.
    
Actual results:

It returns 1.

Expected results:

It should return 0 designated that all was well, and it should return 1
when all is not well.

Additional info:

The following is a patch to fix the problem:

--- anaconda-8.0.95/isomd5sum/checkisomd5.c.orig        2003-03-07 
10:54:20.000000000 -0500
+++ anaconda-8.0.95/isomd5sum/checkisomd5.c     2003-03-07 10:55:01.000000000 -
0500
@@ -323,4 +323,6 @@
     }
 
     rc = mediaCheckFile(argv[1]);
+
+    exit(rc ? 0 : 1);
 }

Comment 1 Michael Fulbright 2003-03-07 19:18:50 UTC
Thanks I'll put this on our developement version of anaconda.