Bug 858085
| Summary: | Review Request: mingw-qt5-qtxmlpatterns - Qt5 for Windows - QtXmlPatterns component | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Erik van Pienbroek <erik-fedora> |
| Component: | Package Review | Assignee: | Kalev Lember <kalevlember> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-mingw, kalevlember, package-review |
| Target Milestone: | --- | Flags: | kalevlember:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | mingw-qt5-qtwebsockets-5.4.1-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-31 21:48:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 858058 | ||
| Bug Blocks: | |||
|
Description
Erik van Pienbroek
2012-09-17 22:53:44 UTC
Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://build1.openftd.org/fedora-cross/src/mingw-qt5-qtxmlpatterns-5.0.0-0.2.beta1.git20121112.69b7a0bb.fc19.src.rpm * Mon Nov 12 2012 Erik van Pienbroek <epienbro> - 5.0.0-0.2.beta1.git20121112.69b7a0bb - Update to 20121112 snapshot (rev 69b7a0bb) - Rebuild against latest mingw-qt5-qtbase - Dropped pkg-config rename hack as it's unneeded now Updated Spec URL: http://svn.openftd.org/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.1/1.fc19/src/mingw-qt5-qtxmlpatterns-5.0.1-1.fc19.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=123 * Sat Feb 09 2013 Erik van Pienbroek <epienbro> - 5.0.1-1 - Update to 5.0.1 * Fri Jan 11 2013 Erik van Pienbroek <epienbro> - 5.0.0-1 - Update to Qt 5.0.0 Final Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.0.2/1.fc20/src/mingw-qt5-qtxmlpatterns-5.0.2-1.fc20.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=145 * Fri May 10 2013 Erik van Pienbroek <epienbro> - 5.0.2-1 - Update to 5.0.2 Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.1.0/1.fc20/src/mingw-qt5-qtxmlpatterns-5.1.0-1.fc20.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=156 * Sun Jul 14 2013 Erik van Pienbroek <epienbro> - 5.1.0-1 - Update to 5.1.0 Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0/0.1.rc1.fc21/src/mingw-qt5-qtxmlpatterns-5.2.0-0.1.rc1.fc21.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=181 * Fri Nov 29 2013 Erik van Pienbroek <epienbro> - 5.2.0-0.1.rc1 - Update to 5.2.0 RC1 Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.2.0/1.fc21/src/mingw-qt5-qtxmlpatterns-5.2.0-1.fc21.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=185 * Sun Jan 05 2014 Erik van Pienbroek <epienbro> - 5.2.0-1 - Update to 5.2.0 - Dropped manual rename of import libraries - Added license files Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.3.0/1.fc21/src/mingw-qt5-qtxmlpatterns-5.3.0-1.fc21.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=214 * Sun May 25 2014 Erik van Pienbroek <epienbro> - 5.3.0-1 - Update to 5.3.0 Updated Spec URL: http://svn.nntpgrab.nl/svn/fedora_cross/mingw-qt5-qtxmlpatterns/mingw-qt5-qtxmlpatterns.spec Updated SRPM URL: http://koji.vanpienbroek.nl/kojifiles/packages/mingw-qt5-qtxmlpatterns/5.4.1/1.fc23/src/mingw-qt5-qtxmlpatterns-5.4.1-1.fc23.src.rpm Koji scratch build: http://koji.vanpienbroek.nl/koji/buildinfo?buildID=259 * Tue Mar 24 2015 Erik van Pienbroek <epienbro> - 5.4.1-1 - Update to 5.4.1 Fedora review mingw-qt5-qtxmlpatterns-5.4.1-1.fc23.src.rpm 2015-03-25
$ rpmlint mingw-qt5-qtxmlpatterns-5.4.1-1.fc22.src.rpm \
mingw32-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \
mingw64-qt5-qtxmlpatterns-5.4.1-1.fc22.noarch.rpm \
mingw32-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm \
mingw64-qt5-qtxmlpatterns-debuginfo-5.4.1-1.fc22.noarch.rpm
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{qt_module}
mingw-qt5-qtxmlpatterns.src:29: W: macro-in-comment %{snapshot_rev}
mingw32-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources
mingw64-qt5-qtxmlpatterns-debuginfo.noarch: E: debuginfo-without-sources
5 packages and 0 specfiles checked; 2 errors, 4 warnings.
+ OK
! needs attention
+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora MinGW packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The stated license for the mingw package is the same as the one for the
corresponding native Fedora package
! The license text is included in %license
Can you use %license instead of %doc for the license files, please?
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
ec2970e9e9c38f88be74f18101937c28 qtxmlpatterns-opensource-src-5.4.1.tar.xz
ec2970e9e9c38f88be74f18101937c28 Download/qtxmlpatterns-opensource-src-5.4.1.tar.xz
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
n/a ldconfig in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all the directories it creates
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
n/a Development files should be in -devel
Not applicable to MinGW packages.
n/a -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
Looks good to me, just a minor problem with the %license vs %doc macros -- the guidelines were recently updated to require the %license macro for license files. Please fix this before importing.
APPROVED
Thanks for the review! New Package SCM Request ======================= Package Name: mingw-qt5-qtxmlpatterns Short Description: Qt5 for Windows - QtXmlPatterns component Upstream URL: http://www.qt.io/ Owners: epienbro Branches: f20 f21 f22 epel7 InitialCC: Git done (by process-git-requests). mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc22,mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc21,mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.fc20,mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mingw-qt5-qtwebsockets-5.4.1-1.el7,mingw-qt5-qtxmlpatterns-5.4.1-1.el7 mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. mingw-qt5-qtwebsockets-5.4.1-1.fc22, mingw-qt5-qtxmlpatterns-5.4.1-1.fc22 has been pushed to the Fedora 22 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.fc21, mingw-qt5-qtxmlpatterns-5.4.1-1.fc21 has been pushed to the Fedora 21 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.fc20, mingw-qt5-qtxmlpatterns-5.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. mingw-qt5-qtwebsockets-5.4.1-1.el7, mingw-qt5-qtxmlpatterns-5.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. |