Bug 858204

Summary:	The libvirt augeas lens can't parse a libvirtd.conf file where host_uuid is present
Product:	Red Hat Enterprise Linux 6	Reporter:	Federico Simoncelli <fsimonce>
Component:	libvirt	Assignee:	Libvirt Maintainers <libvirt-maint>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	6.3	CC:	acathrow, berrange, bili, dallan, dyasny, dyuan, eblake, jdenemar, jpallich, mzhan, rwu, zhpeng
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-0.10.1-2.el6	Doc Type:	Bug Fix
Doc Text:	When the host_uuid option was present in the libvirtd.conf file, the augeas libvirt lens was unable to parse the file. This bug has been fixed and the augeas libvirt lens now parses libvirtd.conf as expected in the described scenario.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 07:24:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	858988

Description Federico Simoncelli 2012-09-18 10:13:17 UTC

Description of problem:
The augeas libvirt lens isn't able to parse a libvirtd.conf file where the host_uuid option is present.

Version-Release number of selected component (if applicable):
libvirt-0.9.10-21.el6_3.4

How reproducible:
100%

Steps to Reproduce:
1. augtool ls /files/etc/libvirt/libvirtd.conf | wc -l
2. echo host_uuid=\"00000000-0000-0000-0000-000000000000\" >> /etc/libvirt/libvirtd.conf
3. augtool ls /files/etc/libvirt/libvirtd.conf | wc -l
  
Actual results:
The augeas libvirt lens can't parse libvirtd.conf anymore.

Expected results:
The augeas libvirt lens must be able to parse libvirtd.conf.

Additional info:
Upstream patch: a9c779c Fix mistakes in augeas lens

Comment 1 Daniel Berrangé 2012-09-18 10:21:23 UTC

Upstream change is entirely self-contained to the augeas lens files, so it is zero risk to the actual libvirt code.

$ git show a9c779c | diffstat
 daemon/libvirtd.aug        |    4 ++++
 src/qemu/libvirtd_qemu.aug |    2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

Comment 2 Daniel Berrangé 2012-09-18 10:23:00 UTC

Already incorporated in the RHEL-6.4 build of libvirt 0.10.

Comment 3 Eric Blake 2012-09-18 12:40:08 UTC

(In reply to comment #2)
> Already incorporated in the RHEL-6.4 build of libvirt 0.10.

Needs to also go into 6.3.z.  Also, there was a bad backport for bug 838819 during 0.9.10-21.el6_3.3, which needs this fix:

diff --git a/src/locking/test_libvirt_sanlock.aug
b/src/locking/test_libvirt_sanlock.aug
index b00082c..b5169e1 100644
--- a/src/locking/test_libvirt_sanlock.aug
+++ b/src/locking/test_libvirt_sanlock.aug
@@ -4,7 +4,6 @@ module Test_libvirt_sanlock =
 disk_lease_dir = \"/var/lib/libvirt/sanlock\"
 host_id = 1
 require_lease_for_disks = 1
-ignore_readonly_and_shared_disks = 1
 "

    test Libvirt_sanlock.lns get conf =

Comment 4 Eric Blake 2012-09-18 21:02:59 UTC

Once the z-stream bug is created, we can move it to POST.
http://post-office.corp.redhat.com/archives/rhvirt-patches/2012-September/msg00528.html

Comment 9 zhpeng 2012-09-29 07:07:24 UTC

[root@zhpeng ~]# augtool ls /files/etc/libvirt/libvirtd.conf | wc -l
407
[root@zhpeng ~]#  echo host_uuid=\"00000000-0000-0000-0000-000000000000\" >> /etc/libvirt/libvirtd.conf
[root@zhpeng ~]#  augtool ls /files/etc/libvirt/libvirtd.conf | wc -l
408


pkg: libvirt-0.10.2-1.el6.x86_64

VERIFIED.

Comment 10 errata-xmlrpc 2013-02-21 07:24:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html