Bug 858968
Summary: | rhevm-image-uploader: Error message are not clear to common user and help message is shown even if tool failed with error that is not related to parameters parsing [TEXT] | ||
---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Ilia Meerovich <iliam> |
Component: | ovirt-image-uploader | Assignee: | Keith Robertson <kroberts> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Ilanit Stein <istein> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 3.0.5 | CC: | acathrow, dyasny, iheim, jmoran, mgoldboi, oramraz, Rhev-m-bugs, ykaul |
Target Milestone: | --- | Keywords: | Improvement |
Target Release: | 3.1.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | integration | ||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-12-04 19:59:53 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ilia Meerovich
2012-09-20 08:34:21 UTC
This should be fixed in 3.1.x not the 3.0.x stream. merged downstream: https://gerrit.eng.lab.tlv.redhat.com/gitweb?p=rhevm-image-uploader.git;a=commit;h=d36759323b5820997608dc78ce22bc6053965d90 *** Bug 858970 has been marked as a duplicate of this bug. *** 1. Running rhevm-image-uploader with empty ovf file, indeed give a clear error, without giving help menu, and this is OK: log: [root@lilach-rhel tmp]# rhevm-image-uploader -u admin@internal -r lilach-rhel.qa.lab.tlv.redhat.com:443 -e export_domain upload template.ovf Please provide the REST API password for the admin@internal RHEV-M user (CTRL+D to abort): ERROR: This archive does not contain an OVF XML file. But, this requires a fix: 2.Running rhevm-image-uploader with CORRECT syntax and wrong port results: a. Error which is not clear to user (ERROR: 'NoneType' object is not iterable). b. Give info on how to run help (INFO: Use the -h option to see usage.) log: [root@lilach-rhel tmp]# rhevm-image-uploader -u admin@internal -r lilach-rhel.qa.lab.tlv.redhat.com:8080 -e export_domain upload /home/art_template.ovf Please provide the REST API password for the admin@internal RHEV-M user (CTRL+D to abort): ERROR: Problem connecting to the REST API. Is the service available and does the CA certificate exist? ERROR: 'NoneType' object is not iterable INFO: Use the -h option to see usage. (In reply to comment #7) > 1. Running rhevm-image-uploader with empty ovf file, indeed give a clear > error, > without giving help menu, and this is OK: > log: > [root@lilach-rhel tmp]# rhevm-image-uploader -u admin@internal -r > lilach-rhel.qa.lab.tlv.redhat.com:443 -e export_domain upload template.ovf > Please provide the REST API password for the admin@internal RHEV-M user > (CTRL+D to abort): > ERROR: This archive does not contain an OVF XML file. > > But, this requires a fix: > > 2.Running rhevm-image-uploader with CORRECT syntax and wrong port results: > a. Error which is not clear to user (ERROR: 'NoneType' object is not > iterable). > b. Give info on how to run help (INFO: Use the -h option to see usage.) > > log: > > [root@lilach-rhel tmp]# rhevm-image-uploader -u admin@internal -r > lilach-rhel.qa.lab.tlv.redhat.com:8080 -e export_domain upload > /home/art_template.ovf > Please provide the REST API password for the admin@internal RHEV-M user > (CTRL+D to abort): > ERROR: Problem connecting to the REST API. Is the service available and > does the CA certificate exist? > ERROR: 'NoneType' object is not iterable > INFO: Use the -h option to see usage. You are now running into a completely different problem and, I would prefer a different BZ to solve it. I think that the original issue was solved patch in comment 2. The new problem you are encountering is the following: - The system upon which you are running the rhevm-image-uploader most likely does *not* have a valid CA certificate for lilach-rhel.qa.lab.tlv.redhat.com or you typed the PW wrong. The tool prints an appropriate error message [1]; however, there is a small bug that prints [2]. [2] isn't related to this original BZ (it looks the same) but it is a different problem. The root cause for [2] is that the code is expecting a 3 tuple but is receiving 'None' from the API creation code. [1] ERROR: Problem connecting to the REST API. Is the service available and does the CA certificate exist? [2] ERROR: 'NoneType' object is not iterable Ilanit, I'm moving this bug to ON_QA please verify this specific issue and open an additional bug on the issue you are having. Verified on SI24.1: help menu and error that appeared originally no longer appear. Opened a new bug following comment 8 - Bug 876554. |