Bug 859233

Summary:	ovirt-engine-restapi : two permissions has the same permit ID
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Oded Ramraz <oramraz>
Component:	ovirt-engine-restapi	Assignee:	Oved Ourfali <oourfali>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Oded Ramraz <oramraz>
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.1.0	CC:	dyasny, ecohen, iheim, lpeer, mpastern, Rhev-m-bugs, sgrinber, yeylon, ykaul, yzaslavs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	si20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-04 20:01:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Oded Ramraz 2012-09-20 20:53:52 UTC

Description of problem:

two permissions contain the same permit ID :

<permit id="1104"><name>delete_disk</name><administrative>false</administrative></permit>
<permit id="1104"><name>port_mirroring</name><administrative>true</administrative></permit>

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Itamar Heim 2012-09-20 21:15:13 UTC

oved/yair - maybe also add a unitest to check no duplicate permits in the enum?
(i'd add this unitest to run on all enums actually!)

this will require a release note, since we won't handle upgrade on this...

Comment 2 Oved Ourfali 2012-09-23 06:22:34 UTC

The problem is in the restapi side, and not backend side.
There is a PermitType enum in the restapi-definition project, and the permit ID there for the port mirroring is wrong.

Movig the bug to restapi component.

Comment 3 Itamar Heim 2012-09-23 06:53:38 UTC

why would we maintain these numbers manually in the code?

Comment 4 Michael Pasternak 2012-09-23 07:29:13 UTC

leftover from 2.3, enum member's id should be inherited from the BE
enum, and not being specified in the client side decorating enum,

Oved, please remove id from the org.ovirt.engine.api.model.PermitType 
and inject it in the PermitMapper according to the ActionGroup,

thanks.

Comment 5 Oved Ourfali 2012-09-23 10:08:12 UTC

Posted fix:
http://gerrit.ovirt.org/#/c/8128/

Comment 6 Oved Ourfali 2012-09-23 10:33:37 UTC

Commit: c41d40f1483a861d5a007f0579c5d40fcf3c3ce0

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=c41d40f1483a861d5a007f0579c5d40fcf3c3ce0

Comment 9 Oded Ramraz 2012-10-09 14:05:48 UTC

<permit id="1104"><name>delete_disk</name><administrative>false</administrative></permit><permit id="1200"><name>port_mirroring</name><administrative>true</administrative></permit>

The ID's are different now

Verified si20