Bug 860711
| Summary: | Segfault on startup if corosync.conf is wrong | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] Corosync Cluster Engine | Reporter: | Nik Martin <nik.martin> | ||||||
| Component: | unknown | Assignee: | Jan Friesse <jfriesse> | ||||||
| Status: | CLOSED UPSTREAM | QA Contact: | |||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 1.4 | CC: | asalkeld, jfriesse, sdake | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 861032 (view as bug list) | Environment: | |||||||
| Last Closed: | 2012-09-27 12:01:21 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 861032 | ||||||||
| Attachments: |
|
||||||||
Pretty nasty bug. Main problem is hidden in "ringnumber: 2" line. We have dynamically allocated array with size of 2 and we are using direct indexing of ringnumber for that array (so we are using item 3). This bug affects ALL releases RHEL 6 and also upstream master! Many thanks for pointing this bug out. Created attachment 617999 [details]
Proposed patch
Don't access invalid mem in totemconfig interfaces
When ringnumber in config file was set to value bigger or equal to
INTERFACE_MAX, we are using this big value as index to totemconfig
interfaces array, resulting to access to invalid memory and segfault.
Instead of that, ringnumber is now checked and proper error message is
printed if value is too big.
Patch pushed to upstream git both for master and needle/needle-2.0/flatiron/flatiron-1.4 branches. |
Created attachment 617571 [details] corosync.crash Description of problem: Moved config files forward from a 6.2_el6 version of Corosync. Made minor change to config to use different multicast address than an existing corosync on same network. Version-Release number of selected component (if applicable): corosync-1.4.1-7.el6_3.1.x86_64 How reproducible: Have an invalid config file, start corosync. Steps to Reproduce: 1. use the config file attached 2. start corosync 3. Actual results: *** glibc detected *** corosync: corrupted double-linked list: 0x0000000001cca190 *** Under gdb: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6e581e3 in _int_malloc () from /lib64/libc.so.6 Expected results: Corosync to tell me it has an invalid config and exit Additional info: