Bug 860780
| Summary: | output from aeolus-restart-services is misleading, reports both success and failure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] CloudForms Cloud Engine | Reporter: | Giulio Fidente <gfidente> | ||||||
| Component: | aeolus-configure | Assignee: | Steve Linabery <slinaber> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Rehana <aeolus-qa-list> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 1.1.0 | CC: | dajohnso, dmacpher, lbrindle, morazi, slinaber, sshveta | ||||||
| Target Milestone: | beta3 | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: |
When 'aeolus-restart-services' attempted to stop an already stopped service, it reported '[FAILED]' even if the exit performed cleanly. This created potentially confusing output, with actions reporting both success and failure. This update changes this behavior and the STDOUT output is now discarded if the exit status is 0. The STDOUT output is still reported where the exit status is something other than 0. The resulting output is now understandable and displays successful restart attempts.
|
Story Points: | --- | ||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-12-04 15:21:54 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Giulio Fidente
2012-09-26 17:04:31 UTC
I'd just like to mention that all the scripts (with the possible exception of the deltacloud-core initscript, but that may be a bug) exit 0, but the output from `service foo stop` is often '[FAILED]' even if the exit is clean.
So my fix for this is to discard the STDOUT output from `service foo {action}` if the exit status from the system process is zero. We still output the STDOUT from `service` if it exits non-zero.
Commit in master: 04228ee74886bc13dd29e9f00946e7983a5f0646 Commit in 1.1: d391a97762e1dad656b443be8a2437436c58fa5a Created attachment 620564 [details]
log file
Stopped some services and restarted aeolus-services.
As shown in the attached log file .. the O/p of "service foo stop" is not displayed and only sucess is displayed if the service is restarted sucessfully
rpm -qa|grep aeolus
aeolus-conductor-doc-0.13.16-1.el6cf.noarch
aeolus-configure-2.8.8-1.el6cf.noarch
rubygem-aeolus-cli-0.7.3-1.el6cf.noarch
rubygem-aeolus-image-0.3.0-12.el6.noarch
aeolus-conductor-0.13.16-1.el6cf.noarch
aeolus-conductor-daemons-0.13.16-1.el6cf.noarch
aeolus-all-0.13.16-1.el6cf.noarch
However i think colon needs to be removed from Success [root@dell-pe1800-01 ~]# aeolus-check-services Checking mongod ... Success: Checking iwhd ... Success: Checking postgresql ... Success: Checking httpd ... Success: Checking deltacloud-core ... Success: Checking libvirtd ... Success: Checking aeolus-conductor ... Success: Checking conductor-delayed_job ... Success: Checking conductor-dbomatic ... Success: Checking imagefactory ... Success: Checking ntpd ... FAILURE: ntpd is stopped Colon should be displayed only if there is a message like in case of Failure. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHEA-2012-1516.html |