Bug 861040

Summary: nodejs app can not be stopped after add hot_deploy marker
Product: OKD Reporter: Meng Bo <bmeng>
Component: ContainersAssignee: Bill DeCoste <wdecoste>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: 2.xCC: jhou, mpatel, wsun, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-06 18:50:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Meng Bo 2012-09-27 11:28:21 UTC
Description of problem:
After add hot_deploy marker to nodejs app, the app cannot be stopped by rhc cli or ctl_app.sh

Version-Release number of selected component (if applicable):
devenv_2242

How reproducible:
always

Steps to Reproduce:
1.Create nodejs app
2.Add hot_deploy marker
3.Try to stop the app
  
Actual results:
App will keep running status all the time. And can be accessed via web browser.

# rhc app status no1

RESULT:
Application 'no1' is running

# rhc app stop no1

RESULT:
Success

# rhc app status no1

RESULT:
Application 'no1' is running


Expected results:
App can be stopped.

Additional info:
development log:
==========================
[32746] INFO  Started POST "/broker/cartridge" for 203.114.244.88 at Thu Sep 27 07:23:19 -0400 2012
[32746] INFO    Processing by LegacyBrokerController#cartridge_post as 
[32746] INFO    Parameters: {"password"=>"[FILTERED]", "json_data"=>"{\"app_name\":\"no1\",\"api\":\"1.1.3\",\"rhlogin\":\"bmeng\",\"action\":\"stop\"}"}
[32746] DEBUG User-Agent = 'rhc/0.99.2 (ruby 1.8.7; i686-linux)'
[32746] DEBUG MongoDataStore.find(CloudUser, bmeng, bmeng)
[32746] DEBUG DEBUG: rpc_exec_direct: rpc_client=#<MCollective::RPC::Client:0x7ff9be21d648>
[32746] DEBUG DEBUG: rpc_client.custom_request('cartridge_do', {:cartridge=>"nodejs-0.6", :action=>"stop", :args=>"'no1' 'bmengdev' 'dea07f2c077c41d1bc1a484086d5dc34'"}, @id, {'identity' => @id})
[32746] DEBUG DEBUG: [#<MCollective::RPC::Result:0x7ff9be1bec88 @results={:statusmsg=>"OK", :statuscode=>0, :data=>{:exitcode=>0, :output=>"Existing hot deploy marker will remain unchanged\nATTR: status=ALREADY_STOPPED\n"}, :sender=>"ip-10-140-3-15"}, @action="cartridge_do", @agent="stickshift">]
[32746] DEBUG DEBUG: Cartridge command nodejs-0.6::stop exitcode = 0
[32746] DEBUG [REQ_ID=3360ace9b15249b89b127fb07f0246d6] ACTION=LEGACY_CARTRIDGE_POST Processed event stop for application no1
[32746] INFO  Completed 200 OK in 657ms (Views: 1.7ms)

Comment 1 John Poelstra 2012-09-28 18:58:25 UTC
we believe this is fixed in the "typeless fork"

Comment 2 Xiaoli Tian 2012-09-29 03:40:02 UTC
According to Comment1, move it to ON_QA to verify on the latest US2105 fork_ami

Comment 3 Jianwei Hou 2012-09-29 05:21:41 UTC
Verified on fork_ami_2105_189

Steps:
1.Create nodejs app
2.Add hot_deploy marker and git push
3.Try to stop the app

Result:
hjw@my nodejs1$ rhc app stop -a nodejs1 
Password: ******


RESULT:
Success
hjw@my nodejs1$ rhc app status -a nodejs1
Password: ***


RESULT:
Application 'nodejs1' is either stopped or inaccessible

Access webpage, service is unavailable.